Page MenuHomePhabricator
Create Task
Maniphest T189563

Translate incompatible with MW 1.29
Closed, ResolvedPublic
Actions

Description

https://www.mediawiki.org/wiki/Topic:U982ucpc87l3rjcf

Adding is_callable should fix it.

Details

SubjectRepoBranchLines +/-
Fix a compatibility issue with MediaWiki 1.29mediawiki/extensions/Translatemaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

Nikerabbit created this task.Mar 13 2018, 7:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 13 2018, 7:59 AM
Pginer-WMF added a project: Language-2018-Apr-June.Apr 3 2018, 7:24 AM
Pginer-WMF moved this task from Backlog to Maintenance backlog on the Language-2018-Apr-June board.
Arrbee mentioned this in T191292: Release MLEB 2018.04.Apr 3 2018, 1:01 PM
Nikerabbit added a comment.Apr 5 2018, 7:42 AM

I checked in https://3v4l.org/AukDt that is_callable returns false for protected methods.

gerritbot subscribed.Apr 5 2018, 7:47 AM

Change 424228 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Fix a compatibility issue with MediaWiki 1.29

https://gerrit.wikimedia.org/r/424228

gerritbot added a project: Patch-For-Review.Apr 5 2018, 7:47 AM
Nikerabbit claimed this task.Apr 5 2018, 7:47 AM
Nikerabbit moved this task from Maintenance backlog to In Review on the Language-2018-Apr-June board.
Arrbee triaged this task as Medium priority.Apr 5 2018, 8:17 AM
gerritbot added a comment.Apr 6 2018, 5:30 AM

Change 424228 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix a compatibility issue with MediaWiki 1.29

https://gerrit.wikimedia.org/r/424228

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)).Apr 6 2018, 6:00 AM
KartikMistry moved this task from In Review to QA on the Language-2018-Apr-June board.Apr 6 2018, 6:03 AM
• Petar.petkovic removed a project: Patch-For-Review.Apr 6 2018, 7:05 AM
Nikerabbit moved this task from QA to Done on the Language-2018-Apr-June board.Apr 23 2018, 7:12 AM
Nikerabbit closed this task as Resolved.Apr 23 2018, 7:38 AM

Tested for MLEB.

KartikMistry moved this task from Backlog to 2018.04 on the MediaWiki Language Extension Bundle board.Jul 3 2018, 7:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL