Page MenuHomePhabricator
Create Task
Maniphest T189582

Ctrl-Click / Cmd-Click in the Compact Language Links panel opens the page in both the current tab and the new tab
Closed, ResolvedPublic
Actions

Description

To reproduce:

  • Make sure CLL is enabled.
  • Go to https://en.wikipedia.org/wiki/ASCII
  • Click on "64 more" under the languages list.
  • Ctrl-Click on Italiano. (Or Command-Click if you're on a Mac.)

Expected:

Observed:

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/UniversalLanguageSelectormaster+8 -2Switch the current tab to the new language only if it was not Ctrl/Command/Shift-Click
mediawiki/extensions/UniversalLanguageSelectormaster+12 -9Update jquery.uls from upstream
Customize query in gerrit

Event Timeline

Amire80 created this task.Mar 13 2018, 12:17 PM
Restricted Application added a project: UniversalLanguageSelector. · View Herald TranscriptMar 13 2018, 12:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Amire80 triaged this task as High priority.Mar 13 2018, 12:18 PM
Amire80 moved this task from Backlog to Appearance and design on the ULS-CompactLinks board.
Amire80 moved this task from Backlog to Compact Language Links on the UniversalLanguageSelector board.
Pginer-WMF added a project: Language-2018-Jan-Mar.Mar 13 2018, 12:34 PM
Pginer-WMF moved this task from Backlog to Maintenance backlog on the Language-2018-Jan-Mar board.
gerritbot added a subscriber: gerritbot.Mar 13 2018, 12:37 PM

Change 419161 had a related patch set uploaded (by Amire80; owner: Amire80):
[mediawiki/extensions/UniversalLanguageSelector@master] Switch the current tab to the new language only if it was not Ctrl-Click

https://gerrit.wikimedia.org/r/419161

gerritbot added a project: Patch-For-Review.Mar 13 2018, 12:37 PM
• Petar.petkovic moved this task from Maintenance backlog to In Review on the Language-2018-Jan-Mar board.Mar 13 2018, 10:53 PM
Arrbee assigned this task to Amire80.Mar 14 2018, 7:04 AM
gerritbot added a comment.Mar 15 2018, 4:26 PM

Change 419773 had a related patch set uploaded (by Amire80; owner: Amire80):
[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.uls from upstream

https://gerrit.wikimedia.org/r/419773

gerritbot added a comment.Mar 15 2018, 4:40 PM

Change 419773 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.uls from upstream

https://gerrit.wikimedia.org/r/419773

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)).Mar 15 2018, 5:01 PM
gerritbot added a comment.Mar 26 2018, 3:40 PM

Change 419161 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Switch the current tab to the new language only if it was not Ctrl/Command/Shift-Click

https://gerrit.wikimedia.org/r/419161

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)); removed MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)).Mar 26 2018, 4:00 PM
Amire80 moved this task from In Review to QA on the Language-2018-Jan-Mar board.Mar 26 2018, 4:02 PM
Etonkovidova added a subscriber: Etonkovidova.Mar 27 2018, 2:18 AM

I'll check the fix in wmf.27 after deployment.

• Petar.petkovic removed a project: Patch-For-Review.Mar 27 2018, 5:00 PM
Etonkovidova added a comment.Apr 3 2018, 4:25 AM

Checked the fix in wmf.27 - works as expected.

Etonkovidova closed this task as Resolved.Apr 3 2018, 4:25 AM
Nikerabbit moved this task from QA to Done on the Language-2018-Jan-Mar board.Apr 3 2018, 6:54 AM
Amire80 added a comment.Apr 3 2018, 7:17 AM

Thanks for the testing!

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL