Fix highlighted states of tools to use CSS only solution
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Mar 14 2018, 11:05 AM

Description

In the fix for T177278 we added this.setFlags( { progressive: true } ); in the setActive method for the tool.

Flags should not be changed dynamically to indicate interaction state (at least not the progressive flag). We should instead apply the relevant styles to the active state.

Details

	Subject	Repo	Branch	Lines +/-
	Use theme rules to define which tools should get blue icons, not flags	oojs/ui	master	+27 -24

Customize query in gerrit

Related Objects

Mentioned In: T189666: Some icons in WMUI not generating progressive coloured version
Mentioned Here: T177278: Highlighted states of active Tools and Toolgroups should be visually equal

Event Timeline

Esanders created this task.Mar 14 2018, 11:05 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2018, 11:05 AM

Esanders updated the task description. (Show Details)Mar 14 2018, 11:41 AM

Change 419401 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Use theme rules to define which tools should get blue icons, not flags

https://gerrit.wikimedia.org/r/419401

gerritbot added a project: Patch-For-Review.Mar 14 2018, 11:46 AM

Esanders claimed this task.Mar 14 2018, 11:47 AM

Esanders added a project: VisualEditor (Current work).

Esanders mentioned this in T189666: Some icons in WMUI not generating progressive coloured version.Mar 14 2018, 2:18 PM

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Mar 14 2018, 9:41 PM

matmarex edited projects, added OOUI; removed OOjs core.Mar 19 2018, 9:57 PM

Change 419401 merged by Bartosz Dziewoński:
[oojs/ui@master] Use theme rules to define which tools should get blue icons, not flags

https://gerrit.wikimedia.org/r/419401

matmarex closed this task as Resolved.Mar 19 2018, 11:03 PM

matmarex removed a project: Patch-For-Review.

matmarex moved this task from Code review to Product owner review on the VisualEditor (Current work) board.