Page MenuHomePhabricator

Better handle block reasons on mobile (specifically templates and HTML comments)
Open, Needs TriagePublic


T165535: Block notices on mobile web for logged-in users provide insufficient information about the block improved the UI of blocks on mobile, but blocks with templates as their block reasons are still troublesome.

Current block notice drawer

Reason for the block
{{anonblock}}: <!-- IP hoping vandalism and disruption: LTA -->

This does not accurately provide the user with the block rationale.

See T165535#4038869 for more discussion on this topic.

Event Timeline

Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptMar 14 2018, 5:56 PM
SPoore added a subscriber: SPoore.Mar 14 2018, 6:20 PM

@TBolliger Can you give more context to this? I'm not sure I understand how this is different from T165535?

dbarratt updated the task description. (Show Details)Mar 28 2018, 3:59 PM

Nevermind, I found T165535#4038869 which has screenshots. :)

Lofhi awarded a token.Oct 23 2018, 1:31 PM
JJMC89 renamed this task from Better handle template block reasons on mobile to Better handle block reasons on mobile.Nov 5 2018, 3:47 AM
JJMC89 updated the task description. (Show Details)
JJMC89 added a subscriber: JJMC89.

I would like to see the reason parsed so that

  1. HTML comments are not shown
  2. and templates are displayed or clickable to display (over the drawer?). (The template should display as it would appear on the page where the user sees the block.)
TBolliger renamed this task from Better handle block reasons on mobile to Better handle block reasons on mobile (specifically templates and HTML comments).Nov 5 2018, 5:09 PM

Renaming to be more specific, for searchability.

  1. I agree.
  2. Most block warning templates are designed for desktop and do not display appropriately on mobile. I don't think they should appear directly in the drawer, but perhaps could be expanded on tap. We'll want to rope in a UI designer to help with this.
Jdlrobson added subscribers: alexhollender, Jdlrobson.

@TBolliger shouldn't this be tagged anti-harassment? Sorry if I'm missing something. Are you looking for input specifically from @alexhollender ?

@TBolliger I'm still confused. This bug was raised by you and my team isn't planning to work on this but it's been marked as "tracking work by other teams". Please let me know if you're expecting something from us here.

I'm not expecting anything from your team and I cannot prioritize this for my team either. It sounds like neither team is planning on working on this in the foreseeable future. No surprise — it will require a lot of work to very little end-user benefit.

Thanks for the clarification @TBolliger ! understood! It will indeed!

Some possible ways to solve this:

  1. Strip templates and/or comments
  2. If the reason has a template or a comment, do not show the reason
  3. If the reason has a template or a comment, replace with a "probable match" reason (e.g. {{spam}} to Inserting spam)

Comments should be stripped. If templates cannot be displayed, then a link to the user's talk page is better than nothing. Details won't always be on there though (e.g. IP range blocks).

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMar 29 2019, 6:46 PM

Summarising my comments from T219661:

On Special:Blocklist we use the commit message parser which only allows links and comments:

{{echo|Template}} [[reason]] ''italics'' '''bold''' you're blocked! /* comment */

On desktop we use the full parser and this is widely used to show reason information. I suspect this was originally an accident as the field is a single line and limited by the same amount as commit messages (currently 500 chars), but given the communities now use this feature widely, it appears there is no going back.