Page MenuHomePhabricator

Start logging highlighted text in Share-A-Fact funnel again
Closed, DeclinedPublic

Description

Versionevent_text = ""highlight event contained textevent_text IS NULL
2.5.187
2.5.188
2.5.189
2.5.190
2.5.191
2.5.194
2.5.195
2.6.196
2.6.197
2.6.198
2.6.199
2.6.200
2.6.201
2.6.203
2.6.204
2.6.205
2.6.206
2.7.208
2.7.220
2.7.221
2.7.222
2.7.223
2.7.224
2.7.225
2.7.226

Looks like it's the handiwork of @Dbrant :P https://github.com/wikimedia/apps-android-wikipedia/commit/e1b156838a98f58a134475525fd3f09e1492bd44

     /** Text in the web view was highlighted. */ 
-    public void logHighlight(String text) {
-        logAction("highlight", text);
+    public void logHighlight() {
+        logAction("highlight", "");
     }

SELECT
  LEFT(timestamp, 6) AS yyyymm,
  RIGHT(LEFT(userAgent, 28), 7) AS app_version,
  CASE WHEN event_text IS NULL THEN 'NULL'
    WHEN event_text = '' THEN 'empty'
    ELSE 'non-NULL, non-empty' END AS highlighted_text,
  COUNT(*) AS events
FROM MobileWikiAppShareAFact_12588711
WHERE timestamp >= '20180101'
  AND INSTR(userAgent, '-r-') > 0 -- release version
  AND event_action = 'highlight'
  AND INSTR(userAgent, 'Android') > 0
GROUP BY yyyymm, app_version, highlighted_text;