Page MenuHomePhabricator
Create Task
Maniphest T189752

ThanksHooks::insertThankLink: Call to a member function getUser() on a non-object (null)
Closed, ResolvedPublic2 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Spotted in production: Call to a member function getUser() on a non-object (null)

Urls look like: commons.wikimedia.org/wiki/File:Natur.jpg.jpg (so far the only URL we've seen)

Stacktrace:

#0 /srv/mediawiki/php-1.31.0-wmf.25/extensions/Thanks/includes/ThanksHooks.php(397): ThanksHooks::insertThankLink(NULL, NULL, NULL, User)
#1 /srv/mediawiki/php-1.31.0-wmf.25/includes/Hooks.php(177): ThanksHooks::onLogEventsListLineEnding(LogEventsList, string, DatabaseLogEntry, array, array)
#2 /srv/mediawiki/php-1.31.0-wmf.25/includes/Hooks.php(205): Hooks::callHook(string, array, array, NULL)
#3 /srv/mediawiki/php-1.31.0-wmf.25/includes/logging/LogEventsList.php(422): Hooks::run(string, array)
#4 /srv/mediawiki/php-1.31.0-wmf.25/includes/logging/LogPager.php(365): LogEventsList->logLine(stdClass)
#5 /srv/mediawiki/php-1.31.0-wmf.25/includes/pager/IndexPager.php(445): LogPager->formatRow(stdClass)
#6 /srv/mediawiki/php-1.31.0-wmf.25/includes/logging/LogEventsList.php(657): IndexPager->getBody()
#7 /srv/mediawiki/php-1.31.0-wmf.25/includes/page/ImagePage.php(601): LogEventsList::showLogExtract(OutputPage, array, string, string, array)
#8 /srv/mediawiki/php-1.31.0-wmf.25/includes/page/ImagePage.php(138): ImagePage->openShowImage()
#9 /srv/mediawiki/php-1.31.0-wmf.25/includes/actions/ViewAction.php(68): ImagePage->view()
#10 /srv/mediawiki/php-1.31.0-wmf.25/includes/MediaWiki.php(500): ViewAction->show()
#11 /srv/mediawiki/php-1.31.0-wmf.25/includes/MediaWiki.php(294): MediaWiki->performAction(ImagePage, Title)
#12 /srv/mediawiki/php-1.31.0-wmf.25/includes/MediaWiki.php(861): MediaWiki->performRequest()
#13 /srv/mediawiki/php-1.31.0-wmf.25/includes/MediaWiki.php(524): MediaWiki->main()
#14 /srv/mediawiki/php-1.31.0-wmf.25/index.php(42): MediaWiki->run()
#15 /srv/mediawiki/w/index.php(3): include(string)
#16 {main}

Likely culprit: https://gerrit.wikimedia.org/r/#/c/415803/

Details

SubjectRepoBranchLines +/-
Add revision-thanking links to some log entriesmediawiki/extensions/Thanksmaster+83 -17
Customize query in gerrit

Related Objects

Event Timeline

• demon created this task.Mar 14 2018, 9:50 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 14 2018, 9:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy added subscribers: Samwilson, Reedy.Mar 14 2018, 10:02 PM

Breaks CI too

21:59:34 1) ApiCoreThankIntegrationTest::testMediaWikiTestCaseParentSetupCalled
21:59:34 BadMethodCallException: Call to a member function getId() on a non-object (null)
21:59:34 
21:59:34 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/extensions/Thanks/tests/phpunit/ApiCoreThankIntegrationTest.php:37
21:59:34 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:420
21:59:34 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/maintenance/doMaintenance.php:94
Stashbot subscribed.Mar 14 2018, 10:13 PM

Mentioned in SAL (#wikimedia-operations) [2018-03-14T22:13:06Z] <reedy@tin> Synchronized php-1.31.0-wmf.25/extensions/Thanks: T189752 (duration: 01m 16s)

matmarex subscribed.Mar 14 2018, 10:38 PM

The CI issue is probably unrelated, thanks CI has been broken for a long time: T151878

matmarex added a comment.Mar 14 2018, 10:39 PM

Problematic patch already reverted: https://gerrit.wikimedia.org/r/#/c/419596/

• Niharika added a project: Community-Tech-Sprint.Mar 14 2018, 11:18 PM
Samwilson claimed this task.Mar 15 2018, 12:02 AM
Samwilson moved this task from Ready to In Development on the Community-Tech-Sprint board.
gerritbot subscribed.Mar 15 2018, 12:10 AM

Change 419641 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/Thanks@master] Add revision-thanking links to some log entries

https://gerrit.wikimedia.org/r/419641

gerritbot added a project: Patch-For-Review.Mar 15 2018, 12:10 AM
matmarex unsubscribed.Mar 15 2018, 2:07 AM
Samwilson moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Mar 15 2018, 2:18 AM
Etonkovidova subscribed.Mar 16 2018, 6:00 AM

The stacktrace looks very similar to the issue reported in T189663: [betalabs] BadMethodCallException for non-existing page. I'll check after the patch will be merged.

gerritbot added a comment.Mar 23 2018, 1:09 AM

Change 419641 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Add revision-thanking links to some log entries

https://gerrit.wikimedia.org/r/419641

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)).Mar 23 2018, 2:00 AM
Etonkovidova mentioned this in T189663: [betalabs] BadMethodCallException for non-existing page.Mar 28 2018, 4:46 PM
• jmatazzoni moved this task from Untriaged to External on the Collaboration-Team-Triage board.Apr 3 2018, 4:51 PM
kaldari set the point value for this task to 2.Apr 3 2018, 10:47 PM
Samwilson closed this task as Resolved.Apr 4 2018, 3:20 AM
Samwilson moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.
• TBolliger moved this task from Q1 2018-19 to Archive on the Community-Tech-Sprint board.Apr 11 2018, 11:52 PM
• Niharika edited projects, added Community-Tech; removed Community-Tech-Sprint.Jun 26 2018, 11:55 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 11:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL