Page MenuHomePhabricator

Add `cite` styles to MinervaNeue
Closed, DeclinedPublic

Description

In T114885 the styles for blockquote were added, but none for cite.
Let's add them as well.

BeforeAfter
image.png (1×2 px, 468 KB)
image.png (1×2 px, 458 KB)

Event Timeline

Send me a patch and I'll merge.

Change 419964 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] Implement cite styles and remove blockquotes.less as special treatment

https://gerrit.wikimedia.org/r/419964

Can you expand the description to have a screenshot, to show what they look like before and after the change?

Change 419964 abandoned by Jdlrobson:
Implement cite styles

Reason:
Will write my thoughts on task

https://gerrit.wikimedia.org/r/419964

Jdlrobson changed the task status from Open to Stalled.Dec 17 2018, 11:52 PM
Jdlrobson triaged this task as Medium priority.

I'm struggling to find any usecases for this and if they are they might benefit from using template styles instead.

In fact it seems like most articles follow the pattern of

Volker said

memorable quote

E.g. https://en.m.wikipedia.org/wiki/Henry_Ford

I've abandoned the patch but I'd like to keep this task open for revisiting at a future date as the patch itself is fine and we might be able to move to a template.

I'd personally like to keep minerva as minimal as possible and work towards removing less common css.

@Volker_E @Jdlrobson is there design needed here, or is this just a code change?

Volker_E lowered the priority of this task from Medium to Lowest.May 22 2019, 4:23 AM

@alexhollender It's just about a code change and it has been stalled on MinervaNeue as Jon hasn't found a clear use case of cite on wikis around. We would pick this up as soon as we're finding ones.
The design is already part of the Style Guide.

I'd like to keep this task open for revisiting at a future date as the patch itself is fine and we might be able to move to a template.

I'd personally like to keep minerva as minimal as possible and work towards removing less common css.

@Jdlrobson: When would that future revisit be? :) Asking as tasks shouldn't remain stalled for years.

Don't think this will go anywhere. Can't proof that MediaWiki or volunteers aren't using cite.