Page MenuHomePhabricator

Fix Source logging in Feed Configuration funnel
Closed, InvalidPublic

Description

In the Feed Configuration schema/funnel, source (from which the user entered the Feed configuration screen) is decoded as follows:

  • -1 = main overflow menu
  • 0 or greater = type of feed card from which the customization was invoked

However, looking at FeedContentType.java#L21-L84 the cards are 1-8. When we look at source in the database, we're somehow getting 18s and 19s in there:

sourceevents
-155051
12431
23137
32974
4568
51300
61724
75031
81622
183760
19311947
SELECT
  event_source AS source,
  COUNT(*) AS events
FROM MobileWikiAppFeedConfigure_17490595
WHERE timestamp >= '20180101' AND timestamp < '20180301'
  AND RIGHT(LEFT(userAgent, 28), 7) > '2.6.206' -- recent versions
  AND INSTR(userAgent, '-r-') > 0 -- release version
  AND INSTR(userAgent, 'Android') > 0 -- android version
GROUP BY source
ORDER BY source;

Event Timeline

@mpopov For this funnel, the source actually refers to the enumeration in CardType.java instead of FeedContentType.java. This explains all of the following:

  • The value of 0 is not present because the CardType of 0 is the "Search" bar at the top of the feed, and does not provide a link to the customization screen.
  • Values of 9 through 17 are also types of cards (or sub-cards) that don't provide a path into customization.
  • The value of 19 is the most prevalent because this is the onboarding card that initially tells the user about customization, and has a prominent button to go to the customization screen.

Let me know if this all makes sense, and feel free to close if this is answered satisfactorily.

@Dbrant thank you so much for clarifying!