Page MenuHomePhabricator

InteractionTimeline loads fonts from Google font CDN
Closed, ResolvedPublic1 Story Points

Description

Font assets such as https://fonts.gstatic.com/s/lato/v14/S6u_w4BMUTPHjxsI5wq_Gwftx9897g.woff2 are loaded from Google's web font CDN without user notification. The anonymization proxy at https://tools-static.wmflabs.org/fontcdn/ should be used instead.

Notes
Web Font Loader supports custom sources.

Alternatively... it would probably be better to drop the font loader completely and just use React Helmet.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2018, 3:58 AM
Reedy triaged this task as High priority.Mar 15 2018, 1:46 PM
dbarratt updated the task description. (Show Details)Mar 15 2018, 4:41 PM
dbarratt updated the task description. (Show Details)Mar 15 2018, 4:56 PM
dbarratt updated the task description. (Show Details)Mar 15 2018, 5:04 PM

@Reedy — does this High priority mean "please fix in March 2018" or "please fix in 2018"?

Reedy added a subscriber: dbarratt.EditedMar 15 2018, 6:37 PM

@Reedy — does this High priority mean "please fix in March 2018" or "please fix in 2018"?

I didn't see it really being "Unbreak Now!" worthy, but it's easy to sort

March 2018... Replacing the assets from Google to the tools source shouldn't really take more than 5-10 minutes to make the changes and get it deployed. Which is enough to fix the bug at hand

Any further improvements like @dbarratt has suggested can be done at a later date, and are beyond the scope of this ticket

TheDJ added a subscriber: TheDJ.Mar 15 2018, 6:49 PM

And also to consider.. If WMF isn't even a good citizen on things like this, then how can we have standing and complain or move the volunteers to do the right thing.

And also to consider.. If WMF isn't even a good citizen on things like this, then how can we have standing and complain or move the volunteers to do the right thing.

Sorry, this ticket is not an appropriate venue for nonconstructive criticism of team practices. We are now aware of this policy and will address this issue in an upcoming sprint.

TheDJ added a comment.Mar 15 2018, 8:24 PM

And also to consider.. If WMF isn't even a good citizen on things like this, then how can we have standing and complain or move the volunteers to do the right thing.

Sorry, this ticket is not an appropriate venue for nonconstructive criticism of team practices. We are now aware of this policy and will address this issue in an upcoming sprint.

non-constructive really ??? wow.

I apologize, @TheDJ — I quickly read your comment as accusatory of my team when we simply were simply not aware of this policy, despite months of code reviews and input.

Krenair added a subscriber: Krenair.

I apologize, @TheDJ

Apology accepted.

dbarratt updated the task description. (Show Details)Mar 19 2018, 2:11 PM
dbarratt claimed this task.Mar 21 2018, 4:46 PM