| Pginer-WMF | |
| Mar 15 2018, 8:39 AM |
| F15946330: 2px-translation-header-correction.png | |
| Mar 21 2018, 2:21 PM |
| F15946332: 1px-translation-header-correction.png | |
| Mar 21 2018, 2:21 PM |
| F15487458: Mar-15-2018 09-24-27.gif | |
| Mar 15 2018, 8:39 AM |
As part of the rearrangement of the translation editor headers (T186874), the header where the publish button is, was made sticky. However, there seems to be a 2px gap on top that shows the content behind the header to be visible, causing unnecessary distraction.
The expected behaviour would be for the sticky header to reach the top edge of the viewport, so no gap is visible.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T76456 Language Engineering tracker of trackers (tracking) | |||
| Invalid | None | T127695 Design polishing for Content Translation | |||
| Resolved | • Petar.petkovic | T189764 CX2: Avoid sticky header gap on top that shows the content behind it |
Change 419822 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Remove gap on sticky translation header
This seems like a bug on webkit based browsers. Firefox was not suffering from flickering (solved by @santhosh in this patch) or from this gap.
Change 419822 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Remove gap on sticky translation header
Change 421015 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Reduce gap correction on sticky translation header
Although this ticket suggested there is 2px offset from the top, and patch to move header 2px up is merged, I have observed that "All translations" button shows 2px correction on webkit browsers is too much and 1px is sufficient. Here are shots, where you can see that correcting by 2px cuts off part of "All translations" button focus border.
| 2px correction | 1px correction |
|---|---|
 |  |
Change 421015 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Reduce gap correction on sticky translation header
Does this mean ticket should be resolved?
Note that this problem was appearing on webkit browsers (like Chrome) and wasn't affecting all the browsers.
@Petar.petkovic - yes, it's Resolved (I thought that moving to Done will mark it as such). With UI issues I usually do a quick check on different browsers (and on Windows too).