Page MenuHomePhabricator
Create Task
Maniphest T189823

Evaluate `target="_blank"` usage on Style Guide pages
Closed, DeclinedPublic
Actions

Description

We've currently using target="_blank" on some external links. Should we provide it consistently within our contents, adding [[ https://mathiasbynens.github.io/rel-noopener/ | rel="noopener" ]] for security reasons (see also T188698) or leave it completely up to the user?

Update: This article is also pointing out [[ https://blog.dareboost.com/en/2017/03/target-blank-links-rel-noopener-performance-security/ | performance issues when setting target="_blank" ]].

Proposed outcome: We should probably not set it. Thoughts?

Related Objects

Event Timeline

Volker_E created this task.Mar 15 2018, 9:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2018, 9:56 PM
Volker_E triaged this task as Lowest priority.Mar 15 2018, 9:56 PM
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)Mar 16 2018, 12:10 AM
Volker_E mentioned this in T188698: Security review for WikimediaUI Style Guide.
Bawolff subscribed.Mar 16 2018, 12:59 AM

The performance concerns (resource contention due to same thread used) seem very slight in a normal use case, imo. I dont think we should worry about that unless we can actively measure the difference.

• Prtksxna added a comment.Mar 20 2018, 5:08 AM

Unless absolutely necessary I'd not add target="_blank" and leave it to the user.

We should probably not set it. Thoughts?

Volker_E added a comment.Nov 20 2018, 10:33 PM

There's an additional use case now, the linking of binary files from the repo's HTML files, like Sketch or Adobe Illustrator files. `target="_blank" is helpful for browser downloads.

Peachey88 subscribed.Nov 24 2018, 2:22 AM
Volker_E closed this task as Declined.Dec 3 2018, 11:44 AM

Don't see this happening now, there are certain links where we rely on target="_blank" and it actually seems more helpful for user causes than hurtful. Can pick this up again, if there are new insights on how to better handle site-external links.

Volker_E moved this task from Backlog to Declined / Duplicate / Invalid on the Wikimedia Design Style Guide board.Dec 3 2018, 1:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL