Make fatal traces pretty (currently they are json with all spaces removed)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Mar 16 2018, 12:41 AM

Description

For some reason, fatal traces (on mwlog) are json with all spaces removed... We should make them more like the exception ones

In T189846#4055337, @Tgr wrote:

Ugh, why are we still using JSON format for fatal traces?

Details

	Subject	Repo	Branch	Lines +/-
	exception: Improve formatting of fatal error log messages	mediawiki/core	master	+18 -4

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T157850 Interacting with Wikimedia logs should be a pleasant experience
Resolved	Krinkle	T89169 Log php fatals with full backtraces again (fatal.log on fluorine)
Resolved	Tgr	T189851 Make fatal traces pretty (currently they are json with all spaces removed)

Event Timeline

Reedy created this task.Mar 16 2018, 12:41 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2018, 12:41 AM

Aklapper renamed this task from Make fatal traces pretty to Make fatal traces pretty (currently they are json with all spaces removed).Mar 16 2018, 9:15 AM

Change 420151 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/core@master] Improve formatting of log messages for fatal errors

https://gerrit.wikimedia.org/r/420151

gerritbot added a project: Patch-For-Review.Mar 17 2018, 2:31 AM

Krinkle added a parent task: T89169: Log php fatals with full backtraces again (fatal.log on fluorine).Mar 21 2018, 7:28 PM

Krinkle moved this task from Backlog to In Dev/Progress on the Wikimedia-Logstash board.Mar 21 2018, 7:32 PM

Change 420151 merged by jenkins-bot:
[mediawiki/core@master] exception: Improve formatting of fatal error log messages

https://gerrit.wikimedia.org/r/420151

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)).Mar 21 2018, 8:01 PM

Tgr closed this task as Resolved.Mar 21 2018, 8:21 PM

Tgr claimed this task.

fgiunchedi added a project: observability.Aug 19 2019, 2:27 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 19 2019, 3:11 PM