Page MenuHomePhabricator
Create Task
Maniphest T189880

Introduce SearchQuery
Closed, ResolvedPublic
Actions

Description

SearchQuery is a immutable class holding all the information known after parsing the query.
This object can be built from a convenient builder class.
It'll be the data that the upcoming query routing mechanism will be based on.
It'll also be the source data for all the query building component.

Details

SubjectRepoBranchLines +/-
Add ContextualFiltermediawiki/extensions/CirrusSearchmaster+180 -15
Add tilde header support to the new parsermediawiki/extensions/CirrusSearchmaster+95 -0
Add support for namespace header in the new parsermediawiki/extensions/CirrusSearchmaster+443 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

dcausse triaged this task as Medium priority.Mar 16 2018, 3:21 PM
dcausse created this task.
Restricted Application edited projects, added Discovery-Search; removed Discovery-Search (Current work). · View Herald TranscriptMar 16 2018, 3:21 PM
dcausse removed a project: Epic.Mar 16 2018, 3:33 PM
dcausse updated the task description. (Show Details)Mar 21 2018, 9:21 AM
dcausse updated the task description. (Show Details)
Smalyshev added a comment.Mar 21 2018, 10:19 PM

What about config and interwiki stuff? I.e., right now interwiki searches also use query builder but with different config. To take decision about how to treat search, this information needs to be available - i.e. Wikibase wants to override local searches in Main space, but not interwiki searches in the same space.

Smalyshev added a comment.Mar 22 2018, 5:33 AM

Most of the time the list of requested namespaces will be the criteria used but what happens if 2 extensions request to override for the same set of ns?

Ideally we don't want two extensions messing with search in the same NS. However, it is completely possible that, for example, somebody searches both Main and User space on Wikidata, and those require different searches. Right now the engine just chooses one, but we could possibly - at least in theory - run several searches. That wouldn't be easy since searches can have different results formats, etc. - so I am not sure whether we should support it at all.

• EBjune moved this task from needs triage to This Quarter on the Discovery-Search board.May 10 2018, 5:29 PM
dcausse mentioned this in T195815: The prefix keyword should augment and not override the list of requested namespaces .Jun 5 2018, 3:57 PM
dcausse moved this task from This Quarter to Current work on the Discovery-Search board.Jun 7 2018, 8:34 AM
dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.
dcausse moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.
debt closed subtask T197774: Add a way to classify queries as Resolved.Jul 9 2018, 11:49 PM
dcausse moved this task from not in use - please delete to Incoming on the Discovery-Search (Current work) board.Jul 12 2018, 1:51 PM
debt closed subtask T198860: Deprecate SearchEngine::replacePrefixes as Resolved.Jul 31 2018, 5:49 PM
dcausse moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.Sep 10 2018, 2:09 PM
gerritbot added a comment.Sep 12 2018, 12:28 PM

Change 460008 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Add support for prefixed namespace in the new parser

https://gerrit.wikimedia.org/r/460008

gerritbot added a project: Patch-For-Review.Sep 12 2018, 12:28 PM
gerritbot added a comment.Sep 13 2018, 9:56 AM

Change 460299 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Add tilde prefix support to the new parser

https://gerrit.wikimedia.org/r/460299

gerritbot added a comment.Sep 20 2018, 4:42 PM

Change 460008 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add support for namespace header in the new parser

https://gerrit.wikimedia.org/r/460008

gerritbot added a comment.Sep 20 2018, 4:49 PM

Change 460299 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add tilde header support to the new parser

https://gerrit.wikimedia.org/r/460299

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 20 2018, 5:00 PM
gerritbot added a comment.Sep 28 2018, 8:23 AM

Change 463432 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Add ContextualFilter

https://gerrit.wikimedia.org/r/463432

gerritbot added a comment.Oct 3 2018, 12:43 AM

Change 463432 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add ContextualFilter

https://gerrit.wikimedia.org/r/463432

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)); removed MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Oct 3 2018, 1:00 AM
dcausse renamed this task from Introduce InitialSearchContext to Introduce SearchQuery.Oct 4 2018, 2:40 PM
dcausse updated the task description. (Show Details)
dcausse moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Oct 4 2018, 2:42 PM
dcausse removed a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).
EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Nov 6 2018, 6:18 PM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 6 2018, 7:01 PM
debt closed this task as Resolved.Nov 9 2018, 4:42 PM
debt closed subtask T204255: Introduce rewrite/second-try strategies as Resolved.Dec 10 2018, 9:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL