Page MenuHomePhabricator

Rename PagedTiffHandlerTest::normaliseParamsBooleanTest to let phpunit run it
Closed, ResolvedPublic

Description

PagedTiffHandlerTest::normaliseParamsBooleanTest is not run by phpunit, because it does not start with test*

The dataProvider normaliseProvider is using some member variable, but there are init in setUp, which is called after the data provider.

Needs some refactoring as tests fail if run

php tests/phpunit/phpunit.php extensions/PagedTiffHandler/tests/
#!/usr/bin/env php
Using PHP 7.1.11-0ubuntu0.17.10.1
PHPUnit 4.8.36 by Sebastian Bergmann and contributors.

..............EEEEE....

Time: 9.04 seconds, Memory: 46.00MB

There were 5 errors:

1) PagedTiffHandlerTest::testNormaliseParamsBoolean with data set #0 (null, array(), false, 'no width')
Error: Call to a member function getMetadata() on null

/var/www/wiki/mediawiki/extensions/PagedTiffHandler/PagedTiffHandler_body.php:743
/var/www/wiki/mediawiki/extensions/PagedTiffHandler/PagedTiffHandler_body.php:480
/var/www/wiki/mediawiki/extensions/PagedTiffHandler/PagedTiffHandler_body.php:255
/var/www/wiki/mediawiki/extensions/PagedTiffHandler/tests/PagedTiffHandlerTest.php:336
/var/www/wiki/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:420
/var/www/wiki/mediawiki/core/maintenance/doMaintenance.php:94

2) PagedTiffHandlerTest::testNormaliseParamsBoolean with data set #1 (null, array('50'), true, 'normal scale')
Error: Call to a member function getMetadata() on null

/var/www/wiki/mediawiki/extensions/PagedTiffHandler/PagedTiffHandler_body.php:743
/var/www/wiki/mediawiki/extensions/PagedTiffHandler/PagedTiffHandler_body.php:480
/var/www/wiki/mediawiki/extensions/PagedTiffHandler/PagedTiffHandler_body.php:255
/var/www/wiki/mediawiki/extensions/PagedTiffHandler/tests/PagedTiffHandlerTest.php:336
/var/www/wiki/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:420
/var/www/wiki/mediawiki/core/maintenance/doMaintenance.php:94

3) PagedTiffHandlerTest::testNormaliseParamsBoolean with data set #2 (null, array('100000000'), true, 'normal scale')
Error: Call to a member function getMetadata() on null

/var/www/wiki/mediawiki/extensions/PagedTiffHandler/PagedTiffHandler_body.php:743
/var/www/wiki/mediawiki/extensions/PagedTiffHandler/PagedTiffHandler_body.php:480
/var/www/wiki/mediawiki/extensions/PagedTiffHandler/PagedTiffHandler_body.php:255
/var/www/wiki/mediawiki/extensions/PagedTiffHandler/tests/PagedTiffHandlerTest.php:336
/var/www/wiki/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:420
/var/www/wiki/mediawiki/core/maintenance/doMaintenance.php:94

4) PagedTiffHandlerTest::testNormaliseParamsBoolean with data set #3 (null, array('50'), false, 'Image > max area')
Error: Call to a member function getMetadata() on null

/var/www/wiki/mediawiki/extensions/PagedTiffHandler/PagedTiffHandler_body.php:743
/var/www/wiki/mediawiki/extensions/PagedTiffHandler/PagedTiffHandler_body.php:480
/var/www/wiki/mediawiki/extensions/PagedTiffHandler/PagedTiffHandler_body.php:255
/var/www/wiki/mediawiki/extensions/PagedTiffHandler/tests/PagedTiffHandlerTest.php:336
/var/www/wiki/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:420
/var/www/wiki/mediawiki/core/maintenance/doMaintenance.php:94

5) PagedTiffHandlerTest::testNormaliseParamsBoolean with data set #4 (null, array('50'), true, 'page out of range')
Error: Call to a member function getMetadata() on null

/var/www/wiki/mediawiki/extensions/PagedTiffHandler/PagedTiffHandler_body.php:743
/var/www/wiki/mediawiki/extensions/PagedTiffHandler/PagedTiffHandler_body.php:480
/var/www/wiki/mediawiki/extensions/PagedTiffHandler/PagedTiffHandler_body.php:509
/var/www/wiki/mediawiki/extensions/PagedTiffHandler/PagedTiffHandler_body.php:253
/var/www/wiki/mediawiki/extensions/PagedTiffHandler/tests/PagedTiffHandlerTest.php:336
/var/www/wiki/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:420
/var/www/wiki/mediawiki/core/maintenance/doMaintenance.php:94

FAILURES!
Tests: 23, Assertions: 120, Errors: 5.

Event Timeline

Change 420182 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/PagedTiffHandler@master] Rename and fixup PagedTiffHandlerTest::normaliseParamsBooleanTest

https://gerrit.wikimedia.org/r/420182

^

These two tests still fail...

		$params = [ 'width' => '50' ];
		$this->assertFalse(
			$this->handler->normaliseParams(  $this->multipage_image, $params ),
			"Image > max area"
		);

		// This should normalise the page, but still return true
		$params = [ 'page' => '50' ];
		$this->assertTrue(
			$this->handler->normaliseParams( $this->mhz_image, $params ),
			"page out of range"
		);

Change 420182 merged by jenkins-bot:
[mediawiki/extensions/PagedTiffHandler@master] Rename and fixup PagedTiffHandlerTest::normaliseParamsBooleanTest

https://gerrit.wikimedia.org/r/420182

Umherirrender assigned this task to Reedy.
Umherirrender triaged this task as Medium priority.