Page MenuHomePhabricator

Selection-box does not close properly
Closed, ResolvedPublic3 Estimated Story Points

Description

There appears to be an issue with how the LookupElement clears its result menu box, this issue was found as part of the AdvancedSearch extension. Whenever users use backspace to clear all search results or click on a search result, the result menu box clears its content but it does not hide itself. This leaves behind an empty box below/above the input field.

Peek 2018-06-29 15-40.gif (497×811 px, 63 KB)

(Note: This ticket description was changed after another related issue was solved externally, this description is now up-to-date and describes a leftover problem. The initial ticket mentioned that this was limited to Timeless and Chromium but it affects all skins / browsers)

Related Objects

Event Timeline

@MichaelSchoenitzer_WMDE can't reproduce this. Is it still valid? Maybe it got fixed along with other improvements we or OOUI made.

@Tonina_Zhelyazkova_WMDE The situation is much better now but there is still a small bug:

Peek 2018-06-29 15-40.gif (497×811 px, 63 KB)

Tim_WMDE renamed this task from Advanced search & Timeless: Selection-box doen't close properly to Advanced search & Timeless: Selection-box does not close properly.Aug 6 2018, 1:14 PM
Tim_WMDE claimed this task.
Tim_WMDE moved this task from Todo to Review on the WMDE-FUN-Sprint-2018-08-06 board.
Tim_WMDE moved this task from Review to Doing on the WMDE-FUN-Sprint-2018-08-06 board.

The issue reported by @MichaelSchoenitzer_WMDE seems to actually affect all browsers and is not limited to just Timeless, looking into it right now.

Tim_WMDE renamed this task from Advanced search & Timeless: Selection-box does not close properly to Selection-box does not close properly.Aug 7 2018, 10:18 AM
Tim_WMDE updated the task description. (Show Details)
Tim_WMDE changed the point value for this task from 2 to 3.

Change 451000 had a related patch set uploaded (by Tim Eulitz; owner: Tim Eulitz):
[oojs/ui@master] Fix LookupElement empty search result menu

https://gerrit.wikimedia.org/r/451000

Tim_WMDE moved this task from Doing to Review on the WMDE-FUN-Sprint-2018-08-06 board.
Tim_WMDE added a subscriber: Tim_WMDE.

Change 451000 merged by jenkins-bot:
[oojs/ui@master] Fix LookupElement empty search result menu

https://gerrit.wikimedia.org/r/451000

The proposed fix has been merged and will be deployed alongside the next OOUI release, so this ticket can probably be considered done.

Change 452872 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.28.0

https://gerrit.wikimedia.org/r/452872

Change 452872 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.28.0

https://gerrit.wikimedia.org/r/452872

Lea_WMDE claimed this task.