Page MenuHomePhabricator
Create Task
Maniphest T189990

Rename FullTextQueryStringQueryBuilder.php to let phpunit run it
Closed, ResolvedPublic
Actions

Description

The CirrusSearch extensions has a file FullTextQueryStringQueryBuilder.php in tests/phpunit/Query which does not end with *Test.php and that means, phpunit will not run the tests in that file.

I would suggest to rename the classes.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Query builder test was not runningmediawiki/extensions/CirrusSearchmaster+4 -0
Customize query in gerrit

Event Timeline

Umherirrender created this task.Mar 18 2018, 6:50 PM
Restricted Application added projects: Discovery-ARCHIVED, Discovery-Search. · View Herald TranscriptMar 18 2018, 6:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• EBjune triaged this task as Medium priority.Mar 29 2018, 5:26 PM
• EBjune moved this task from needs triage to Up Next on the Discovery-Search board.
gerritbot subscribed.Sep 10 2018, 5:20 PM

Change 459586 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@master] Query builder test was not running

https://gerrit.wikimedia.org/r/459586

gerritbot added a project: Patch-For-Review.Sep 10 2018, 5:20 PM
EBernhardson claimed this task.Sep 10 2018, 5:21 PM
EBernhardson edited projects, added: Discovery-Search (Current work); removed: Discovery-Search.
EBernhardson moved this task from Incoming to Needs Reporting on the Discovery-Search (Current work) board.Sep 10 2018, 5:56 PM
gerritbot added a comment.Sep 10 2018, 6:06 PM

Change 459586 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Query builder test was not running

https://gerrit.wikimedia.org/r/459586

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 10 2018, 7:00 PM
Umherirrender closed this task as Resolved.Sep 10 2018, 7:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits