Page MenuHomePhabricator

CX2: Support keyboard indentation shortcuts
Closed, DeclinedPublic

Description

These shortcuts are not working in ContentTranslation VE integration:

(1) Increase indentation Cmd+]
(2) Decrease indentation Cmd+[


There is an additional difference in shortcuts for triggering the CX auto save, so the following behaviour should be preserved:
(3) Save draft - Cmd+S. In VE it will save the edited article as an html file. In ContentTranslation the shortcut triggers auto-save

Event Timeline

Pginer-WMF renamed this task from [cx2-testing] VE shortcuts review to CX2: Support keyboard identation shortcuts.Mar 22 2018, 1:06 PM
Pginer-WMF updated the task description. (Show Details)

(3) Save draft - Cmd+S. In VE it will save the edited article as an html file. In ContentTranslation the shortcut has no effect.

I updated the scope of the ticket. The discrepancy in 3 is expected, so only indentation-related shortcuts seem to be missing.

Pginer-WMF moved this task from Needs Triage to CX2 on the ContentTranslation board.
Nikerabbit renamed this task from CX2: Support keyboard identation shortcuts to CX2: Support keyboard indentation shortcuts.Feb 19 2020, 1:41 PM

Indentation shortcuts actually work, but only on English keyboard layout.
Found these issues while testing:

  • cmd+z doesn't work with images
  • these 2 shortcuts bring up the screenshot tool in apple devices instead of applying the changes on the text

image.png (164×444 px, 11 KB)

  • cite shortcut doesn't work
  • bullet/numbered list button stays highlighted even after we remove the formatting

image.png (426×540 px, 25 KB)

Indentation shortcuts actually work, but only on English keyboard layout.

Are those issues happening only in Content Translation, or are they happening also in Visual Editor?

Indentation shortcuts actually work, but only on English keyboard layout.

Are those issues happening only in Content Translation, or are they happening also in Visual Editor?

they also happen in VE

this is a VE issue