Page MenuHomePhabricator

Prompt user when restoring an auto-save against a new document version
Closed, ResolvedPublic8 Story Points


If the revision ID has changed since the document was first opened, the user is more likely to be facing an edit conflict, and may have deliberately reloaded the page to get the latest wikitext. In this case we can prompt the user if they want to restore their changes, or load the document from scratch.

As discussed in T57370.

Event Timeline

Esanders created this task.Mar 19 2018, 5:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2018, 5:29 PM

Change 419169 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Autosave recovery prompt

Current appearance/wording:

I was imagining a non-modal prompt, more like e.g. the find and replace "dialog".

+1 to Bartosz' feedback
Similar to popup opening prevented feedback in Firefox.

I think blocking the editing of the document until the user chooses which version they want to edit makes sense. This is the same way Word/LibreOffice does document recovery, so will be familiar to users. It's also simpler from a technical & performance point of view.

I agree with Ed. It's not sensible to let users do other things before picking which document they're editing.

@Esanders Your comparison with Word/LibreOffice makes sense, let's see how the user feedback is.

Change 419169 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Autosave recovery prompt

Deskana closed this task as Resolved.Apr 5 2018, 4:23 PM
Deskana triaged this task as Normal priority.
Deskana set the point value for this task to 8.