Page MenuHomePhabricator

Remove .hiddenStructure from CSS
Closed, ResolvedPublic

Description

Author: happy_melon

Description:
It's been deprecated for over three years now, yet we're still forced to manually override this to stop people using the damn thing. If people want to continue using a terrifying hack that royally screws over people with older browsers (vide Brion http://en.wikipedia.org/wiki/Wikipedia_talk:Avoid_using_meta-templates?diff=36124214), they can add the definition themselves, it's not exactly difficult. But given how many other friendlier ways there are of hiding content, it's crazy to leave this in there just because it's been there since forever.

trunk/phase3/skins/monobook/main.css:
@@ 487:

  • .hiddenStructure {
  • display: none;
  • }

Version: unspecified
Severity: minor

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:24 PM
bzimport set Reference to bz17009.
bzimport added a subscriber: Unknown Object (MLST).

Using it for its original purpose (in meta templates?) was bad. Leaving it as a general CSS class declaration for hiding things shouldn't hurt anyone...?

Wiki.Melancholie wrote:

Please note that this class is being used on wikis here and there.
Removal will suddenly unhide stuff on wikis out there making use of this.

If it is removed it should also be removed in css for other skins (modern, vector, and maybe other).

If it is not removed, maybe it should be moved to a skin independent css file. Currently the class is missing for old skins like Standard and CologneBlue.

chinchi29 wrote:

If any wiki still wants to use this class, the sysops can put the class back in the local common.css.

(In reply to comment #4)

If any wiki still wants to use this class, the sysops can put the class back in
the local common.css.

Yes. The biggest wikis already wiped out most of the hiddenstructure usages anyway.

The thing is, since the class still exists editors keep using it. And it's a pain to have to check the templates on a regular basis to ensure nobody tried using it again. And really often, we find yet nother buch of templates that we have to rewrite completely.

So please, let's remove it once and for all.

happy.melon.wiki wrote:

Removed in r85017.

For the record: it is really difficult to get rid of it. We still have at least 400 pages on Portuguese Wikipedia using the old class...

https://pt.wikipedia.org/w/index.php?oldid=31420316&uselang=en

Change 675094 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):
[mediawiki/skins/Truglass@master] Remove .hiddenStructure once again for good

https://gerrit.wikimedia.org/r/675094

Change 675095 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):
[mediawiki/skins/Dusk@master] Remove .hiddenStructure once again for good

https://gerrit.wikimedia.org/r/675095

Change 675095 merged by jenkins-bot:
[mediawiki/skins/Dusk@master] Remove .hiddenStructure once again for good

https://gerrit.wikimedia.org/r/675095

Change 675094 merged by jenkins-bot:
[mediawiki/skins/Truglass@master] Remove .hiddenStructure once again for good

https://gerrit.wikimedia.org/r/675094

Change 800851 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/skins/Cavendish@master] Remove .hiddenStructure CSS class once again

https://gerrit.wikimedia.org/r/800851

Change 800851 merged by jenkins-bot:

[mediawiki/skins/Cavendish@master] Remove .hiddenStructure CSS class once again

https://gerrit.wikimedia.org/r/800851