Maniphest T190142

Use ES5 methods instead of jQuery iterator methods
Closed, ResolvedPublic
Actions

Description

Use .forEach or better yet, inspect the usage of $.each and change it to .map if it is producing a new array, or .reduce if it is collecting a new result based on the array.

We shouldn't use $.each given we can use now the ES5 methods.

Popups => ag --js -Q '$.each'
tests/node-qunit/gateway/mediawiki.test.js
132:    $.each( errorCases, function ( _, data ) {
138:    $.each( successCases, function ( _, data ) {

src/ui/renderer.js
688:    $.each( rects, function ( i, rect ) {

src/formatter.js
61:     $.each( extract, function ( index, part ) {

Acceptance criteria

Fix the issues.
Merge https://gerrit.wikimedia.org/r/420793 to stop them happening again.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Hygiene: restrict use of $.each and fix offenders	mediawiki/extensions/Popups	master	+13 -6

Customize query in gerrit

Event Timeline

• Jhernandez created this task.Mar 20 2018, 12:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2018, 12:56 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog-Archived board.Mar 20 2018, 5:55 PM

Change 420793 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Popups@master] Restrict use of $.each

https://gerrit.wikimedia.org/r/420793

gerritbot added a project: Patch-For-Review.Mar 20 2018, 6:03 PM

Jdlrobson triaged this task as Medium priority.Mar 20 2018, 6:03 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Needs Prioritization to Upcoming on the Web-Team-Backlog-Archived board.

(There's a patch)

Volker_E subscribed.Mar 21 2018, 7:52 PM

Jdlrobson moved this task from Upcoming to 2017-18 Q3 on the Web-Team-Backlog-Archived board.Mar 21 2018, 8:15 PM

Change 420793 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Hygiene: restrict use of $.each and fix offenders

https://gerrit.wikimedia.org/r/420793

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)).Mar 21 2018, 10:00 PM

Joaquin can you sign off this technical task?

Seems ok for now. We can do better at using .map or .reduce but I guess we can address those separately.

Use ES5 methods instead of jQuery iterator methodsClosed, ResolvedPublicActions

Description

Acceptance criteria

Details

Event Timeline

Use ES5 methods instead of jQuery iterator methods
Closed, ResolvedPublic
Actions