Page MenuHomePhabricator

Update VE-extension icons
Closed, ResolvedPublic1 Story Points

Description

Need to be larger for consistency with new 20x20 canvas.

Event Timeline

Esanders created this task.Mar 20 2018, 1:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2018, 1:56 PM

Also icon-parameter in template dialog (and others):

Frame type icons in media:

Table move icons:

Math alignment:

Change 420696 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420696

Change 420694 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420694

matmarex claimed this task.Mar 20 2018, 3:38 PM
matmarex edited projects, added VisualEditor (Current work); removed OOUI.

The patches above align the icons to the new pixel grid, but not the new design guideline (in particular, using the full width or height of the 20px canvas), so most will still have to be re-drawn:

Yes, I consider this a temporary solution. Ideally someone would create new ones, but I would expect that will take longer. That said, I think many of them look okay – the table move icons are probably the worst example, but e.g. the frame type icons look decent next to new icons:

(the missing white "invert" styling is separate issue, filed as T190166)

Change 420779 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Cite@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420779

Change 420783 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Graph@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420783

Change 420786 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Math@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420786

Change 420789 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/ProofreadPage@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420789

Change 420792 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Score@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420792

Change 420794 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/wikihiero@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420794

Change 420696 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420696

Change 421109 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (52b59d337)

https://gerrit.wikimedia.org/r/421109

Change 421109 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (52b59d337)

https://gerrit.wikimedia.org/r/421109

Change 420694 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420694

Change 420779 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420779

Change 420783 merged by jenkins-bot:
[mediawiki/extensions/Graph@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420783

Change 420786 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420786

Change 420789 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420789

Change 420792 merged by jenkins-bot:
[mediawiki/extensions/Score@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420792

Change 420794 merged by jenkins-bot:
[mediawiki/extensions/wikihiero@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420794

Deskana set the point value for this task to 1.Mar 23 2018, 2:13 PM
Deskana triaged this task as Normal priority.
Deskana closed this task as Resolved.