Page MenuHomePhabricator
Create Task
Maniphest T190151

Update VE-extension icons
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
matmarex
Authored By
Esanders
Mar 20 2018, 1:56 PM
Tags
Referenced Files
F15917750: image.png
Mar 20 2018, 5:25 PM
F15916348: image.png
Mar 20 2018, 4:00 PM
F15915301: image.png
Mar 20 2018, 2:16 PM
F15915144: image.png
Mar 20 2018, 2:16 PM
F15915237: image.png
Mar 20 2018, 2:16 PM
F15915034: image.png
Mar 20 2018, 2:16 PM
F15914781: image.png
Mar 20 2018, 1:56 PM
Subscribers
Aklapper
Esanders
gerritbot
Volker_E

Description

Need to be larger for consistency with new 20x20 canvas.

image.png (633×214 px, 23 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update icons for new 20px gridmediawiki/extensions/Mathmaster+5 -5
Update icons for new 20px gridmediawiki/extensions/ProofreadPagemaster+7 -7
Update icons for new 20px gridmediawiki/extensions/Graphmaster+1 -1
Update icons for new 20px gridmediawiki/extensions/wikihieromaster+1 -1
Update icons for new 20px gridmediawiki/extensions/Scoremaster+1 -1
Update icons for new 20px gridmediawiki/extensions/Citemaster+12 -12
Update icons for new 20px gridmediawiki/extensions/VisualEditormaster+10 -10
Update VE core submodule to master (52b59d337)mediawiki/extensions/VisualEditormaster+1 -1
Update icons for new 20px gridVisualEditor/VisualEditormaster+4 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Mar 20 2018, 1:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2018, 1:56 PM
Esanders added a parent task: T177432: Unify and refine WikimediaUI icon set.Mar 20 2018, 1:59 PM
Liuxinyu970226 subscribed.Mar 20 2018, 2:01 PM
Esanders added a comment.Mar 20 2018, 2:16 PM

Also icon-parameter in template dialog (and others):

image.png (211×350 px, 21 KB)

Frame type icons in media:

image.png (83×438 px, 7 KB)

Table move icons:

image.png (200×192 px, 10 KB)

Math alignment:

image.png (78×300 px, 4 KB)

gerritbot subscribed.Mar 20 2018, 3:08 PM

Change 420696 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420696

gerritbot added a project: Patch-For-Review.Mar 20 2018, 3:08 PM

Change 420694 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420694

matmarex claimed this task.Mar 20 2018, 3:38 PM
matmarex edited projects, added VisualEditor (Current work); removed OOUI.
matmarex moved this task from Incoming to In progress on the VisualEditor (Current work) board.
Esanders added a comment.Mar 20 2018, 4:00 PM

The patches above align the icons to the new pixel grid, but not the new design guideline (in particular, using the full width or height of the 20px canvas), so most will still have to be re-drawn:

image.png (200×154 px, 8 KB)

matmarex added a comment.Mar 20 2018, 5:25 PM

Yes, I consider this a temporary solution. Ideally someone would create new ones, but I would expect that will take longer. That said, I think many of them look okay – the table move icons are probably the worst example, but e.g. the frame type icons look decent next to new icons:

image.png (131×428 px, 7 KB)

(the missing white "invert" styling is separate issue, filed as T190166)

gerritbot added a comment.Mar 20 2018, 5:39 PM

Change 420779 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Cite@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420779

gerritbot added a comment.Mar 20 2018, 5:50 PM

Change 420783 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Graph@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420783

gerritbot added a comment.Mar 20 2018, 5:56 PM

Change 420786 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Math@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420786

gerritbot added a comment.Mar 20 2018, 5:59 PM

Change 420789 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/ProofreadPage@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420789

gerritbot added a comment.Mar 20 2018, 6:02 PM

Change 420792 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Score@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420792

gerritbot added a comment.Mar 20 2018, 6:03 PM

Change 420794 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/wikihiero@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420794

matmarex moved this task from In progress to Code review on the VisualEditor (Current work) board.Mar 20 2018, 6:27 PM
Jdforrester-WMF added a project: VisualEditor-EditingTools.Mar 20 2018, 7:12 PM
gerritbot added a comment.Mar 21 2018, 4:44 PM

Change 420696 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420696

gerritbot added a comment.Mar 21 2018, 7:18 PM

Change 421109 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (52b59d337)

https://gerrit.wikimedia.org/r/421109

gerritbot added a comment.Mar 21 2018, 8:28 PM

Change 421109 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (52b59d337)

https://gerrit.wikimedia.org/r/421109

gerritbot added a comment.Mar 21 2018, 8:59 PM

Change 420694 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420694

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)).Mar 21 2018, 9:00 PM
gerritbot added a comment.Mar 21 2018, 9:07 PM

Change 420779 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420779

gerritbot added a comment.Mar 21 2018, 9:07 PM

Change 420783 merged by jenkins-bot:
[mediawiki/extensions/Graph@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420783

gerritbot added a comment.Mar 21 2018, 9:11 PM

Change 420786 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420786

gerritbot added a comment.Mar 21 2018, 9:11 PM

Change 420789 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420789

gerritbot added a comment.Mar 21 2018, 9:11 PM

Change 420792 merged by jenkins-bot:
[mediawiki/extensions/Score@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420792

gerritbot added a comment.Mar 21 2018, 9:11 PM

Change 420794 merged by jenkins-bot:
[mediawiki/extensions/wikihiero@master] Update icons for new 20px grid

https://gerrit.wikimedia.org/r/420794

Volker_E added a project: Design.Mar 21 2018, 10:17 PM
Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Mar 22 2018, 5:38 PM
Jdforrester-WMF removed a project: Patch-For-Review.
• Deskana closed this task as Resolved.Mar 23 2018, 2:13 PM
• Deskana triaged this task as Medium priority.
• Deskana set the point value for this task to 1.
Liuxinyu970226 unsubscribed.Mar 25 2018, 7:23 AM
Volker_E mentioned this in T190967: Align further (VE) icons to icon guidelines.Mar 28 2018, 9:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits