Page MenuHomePhabricator
Create Task
Maniphest T190156

first item in namespace drop-down isn't always preselected
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To
None
Authored By
Charlie_WMDE
Mar 20 2018, 2:17 PM
Tags
Referenced Files
F15915387: Screenshot_20180320_150950.png
Mar 20 2018, 2:17 PM
F15915393: Screenshot_20180320_151142.png
Mar 20 2018, 2:17 PM
F15915379: Screenshot_20180320_150721.png
Mar 20 2018, 2:17 PM
Subscribers
Aklapper
Charlie_WMDE
gerritbot
Lea_WMDE
matmarex
Mooeypoo
thiemowmde
View All 9 Subscribers
Tokens
"Love" token, awarded by Lea_WMDE.

Description

Current situation:
When typing a namepsace-name into the field the first item on the list isn't immediately preselected but actually in the background another list item is selected.

Screenshot_20180320_150721.png (284×779 px, 15 KB)

This results in a completely different item being added to the field when pressing enter in that situation. In this case discussion was added after pressing enter.

Screenshot_20180320_150950.png (128×747 px, 12 KB)

Also after adding and then removing a namespace, the preselection stays on the last selected item and not the top one either.

Screenshot_20180320_151142.png (273×751 px, 18 KB)

Task:
The preselection should always be the top item on the list, unless the user is moving down along the list with his cursor or up- and down buttons.

Criteria:

  • When the drop-down is opened for the first time the top item should be preselected.
  • When a tag was created and all options are shown again, the top item should be preselected.
  • While typing the preselected item should always be the top one of the list that the user currently sees.
  • When the user navigated the list with the up and down buttons the preselection should move accordingly and when the user presses enter the item that was visibly preselected to the user should be added as a tag.

Details

SubjectRepoBranchLines +/-
Preselect first item when searching for namespacemediawiki/extensions/AdvancedSearchmaster+1 -1
MenuSelectWidget: Move 'highlight first item' to end of operationoojs/uimaster+37 -9
Unselect namespace dropdown items before disabling themmediawiki/extensions/AdvancedSearchmaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

Charlie_WMDE created this task.Mar 20 2018, 2:17 PM
Restricted Application added projects: TCB-Team (now WMDE-TechWish), Design. · View Herald TranscriptMar 20 2018, 2:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Charlie_WMDE merged a task: T190154: first item in namespace drop-down isn't always preselected.Mar 20 2018, 3:29 PM
Charlie_WMDE moved this task from Backlog to Tickets ready for pickup on the Advanced-Search board.
Lea_WMDE moved this task from Tickets ready for pickup to Backlog on the Advanced-Search board.Mar 21 2018, 10:42 AM
Lea_WMDE triaged this task as High priority.Mar 21 2018, 10:45 AM
Lea_WMDE moved this task from Backlog to Watching on the Advanced-Search board.
Lea_WMDE mentioned this in T173741: When typing a namespace, the top option should be highlighted and be able to be added with enter.
Lea_WMDE added a project: OOUI.
Lea_WMDE subscribed.EditedMar 21 2018, 10:47 AM

This might be related to the recently deployed T187398: MenuTagMultiselectWidget: The first item should be automatically highlighted+selected when the menu opens

Volker_E added subscribers: Mooeypoo, Volker_E.Mar 22 2018, 5:49 AM

@Mooeypoo time to give this a shot?

thiemowmde subscribed.Mar 23 2018, 4:53 PM

I believe this is an upstream bug in OOUI. I do see two slightly different broken behaviors:

  1. Sometimes it depends on how much I type.
    • When I type a single character, e.g. "M", I can see that the options in the dropdown get reduced to the ones that start with "M", e.g. "MediaWiki", "MediaWiki talk", and so on.
    • But none is selected (no gray backgroud).
    • When pressing enter I realize what happens: there was still the previous selection active in the background, in this case "Article". This gets added when I press enter.
    • When I don't press enter but continue typing, e.g. "Me", the "MediaWiki" namespace gets highlighted now. It appears like some event handler is triggered to early or to late, and the code that updates the gray selection "lags behind".
  2. When I add and remove some namespaces, the behavior described in 1 breaks and not even the second character updates the selection.
    • I believe this might have something to do with the fact that the selection is stuck on a disabled list element (they get disabled the moment they are added).
    • I can see a bright blue highlight on one of the items, independent from the gray one I described in 1. What is this? When I make sure this is gone (e.g. by closing and reopening the dropdown), the behavior described in 1 is back.
gerritbot subscribed.Mar 26 2018, 9:53 AM

Change 421849 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/AdvancedSearch@master] Unselect namespace dropdown items before disabling them

https://gerrit.wikimedia.org/r/421849

gerritbot added a project: Patch-For-Review.Mar 26 2018, 9:53 AM
thiemowmde mentioned this in rEASR7d2e000f8944: Unselect namespace dropdown items before disabling them.Mar 26 2018, 9:56 AM
• Hanna_Petruschat_WMDE moved this task from Incoming to IncomingTCB on the WMDE-Design board.Mar 26 2018, 2:25 PM
Charlie_WMDE moved this task from IncomingTCB to Reported TCB on the WMDE-Design board.May 7 2018, 3:15 PM
Volker_E moved this task from Backlog to Doing on the OOUI board.May 7 2018, 9:57 PM
Lea_WMDE awarded a token.May 8 2018, 8:24 AM
Lea_WMDE added a comment.May 20 2018, 11:02 AM

@Mooeypoo this is the ticket I was talking about

thiemowmde mentioned this in rEASR7a1364e72e52: Unselect namespace dropdown items before disabling them.Jun 3 2018, 4:56 PM
gerritbot added a comment.Jun 8 2018, 10:10 PM

Change 439323 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[oojs/ui@master] SelectWidget: Move 'highlight first item' to end of operation

https://gerrit.wikimedia.org/r/439323

Mooeypoo added a comment.Jun 8 2018, 10:10 PM

The above commit should fix this behavior inside OOUI itself. Thanks for spotting it!

thiemowmde moved this task from Incoming to Advanced Search on the TCB-Team (now WMDE-TechWish) board.Jun 12 2018, 4:06 PM
matmarex subscribed.Jun 13 2018, 1:51 PM

As far as I can tell, AdvancedSearch is not passing highlightOnFilter: true, so nothing ever should be preselected when filtering the input (or "highlighted", as we call it).

Items are only getting preselected/highlighted from MenuTagMultiselectWidget.prototype.onInputChange() → initializeMenuSelection(). That code was introduced fairly recently (T187398), and it seems to overlap the functionality of highlightOnFilter a bit… should be harmless though.

So, first of all, in mw.libs.advancedSearch.ui.NamespaceFilters you need to add highlightOnFilter: true after hideOnChoose: false :) That should fix this bug for you.

@Mooeypoo's patch does not fix anything for AdvancedSearch without that. But it actually fixes a different issue – with highlightOnFilter: true , previously navigating the menu with up/down arrow keys would not work (it would reset the highlight to first item every time).

Lea_WMDE moved this task from Watching to Tickets ready for pickup on the Advanced-Search board.Jun 13 2018, 1:58 PM
gerritbot added a comment.Jun 13 2018, 2:04 PM

Change 439323 merged by jenkins-bot:
[oojs/ui@master] MenuSelectWidget: Move 'highlight first item' to end of operation

https://gerrit.wikimedia.org/r/439323

matmarex removed a project: Patch-For-Review.Jun 13 2018, 2:35 PM
thiemowmde mentioned this in rEASR1c3bf6ef8cc4: Unselect namespace dropdown items before disabling them.Jun 17 2018, 6:45 PM
kai.nissen set the point value for this task to 1.Jun 18 2018, 9:11 AM
Lea_WMDE added a project: WMDE-FUN-Sprint-2018-06-25.Jun 25 2018, 10:02 AM
• Tonina_Zhelyazkova_WMDE claimed this task.Jun 26 2018, 1:39 PM
• Tonina_Zhelyazkova_WMDE moved this task from Todo to Doing on the WMDE-FUN-Sprint-2018-06-25 board.
• Tonina_Zhelyazkova_WMDE added a comment.Jun 26 2018, 2:53 PM

@Mooeypoo @matmarex Thank you for your help!
Seems like the patch wasn't merged to master though. So now even if we set highlightOnFilter to true the arrow navigation would stop working.

• Tonina_Zhelyazkova_WMDE removed • Tonina_Zhelyazkova_WMDE as the assignee of this task.Jun 26 2018, 2:58 PM
• Tonina_Zhelyazkova_WMDE moved this task from Doing to Review on the WMDE-FUN-Sprint-2018-06-25 board.
• Tonina_Zhelyazkova_WMDE subscribed.
• Tonina_Zhelyazkova_WMDE mentioned this in rEASR9a1daf6b3921: [DNM] Always preselect first item in namespace drop-down.Jun 26 2018, 3:00 PM
Volker_E added a comment.Jun 26 2018, 3:36 PM

@Tonina_Zhelyazkova_WMDE Fell sick whole last week and therefore there hasn't been an OOUI release with the patch merged on master yet, so it didn't make it into core either. Or did you test against anything home-made?

• Tonina_Zhelyazkova_WMDE added a comment.Jun 26 2018, 3:39 PM

@Volker_E oh I looked at https://gerrit.wikimedia.org/r/439323 and saw it's +2ed but the post merge build failed, so I thought it's not even on master.

gerritbot added a comment.Jun 26 2018, 9:43 PM

Change 421849 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Unselect namespace dropdown items before disabling them

https://gerrit.wikimedia.org/r/421849

• Tonina_Zhelyazkova_WMDE moved this task from Tickets ready for pickup to In FUN sprint on the Advanced-Search board.Jun 29 2018, 8:14 AM
• Tonina_Zhelyazkova_WMDE moved this task from Review to Blocked externally on the WMDE-FUN-Sprint-2018-06-25 board.Jun 29 2018, 9:21 AM
• Pablo-WMDE mentioned this in T198489: MenuSelectWidget: updateItemVisibility keeps options invisible.Jun 29 2018, 3:10 PM
matmarex added a comment.Jun 29 2018, 9:59 PM
In T190156#4315742, @Tonina_Zhelyazkova_WMDE wrote:

Seems like the patch wasn't merged to master though. So now even if we set highlightOnFilter to true the arrow navigation would stop working.

It's now released in OOUI v0.27.4 and MediaWiki was updated to use it, so you should be able to finally do that.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 5:02 PM
gerritbot added a comment.Jul 5 2018, 3:10 PM

Change 443989 had a related patch set uploaded (by Gabriel Birke; owner: Gabriel Birke):
[mediawiki/extensions/AdvancedSearch@master] Preselect first item when searching for namespace

https://gerrit.wikimedia.org/r/443989

gerritbot added a project: Patch-For-Review.Jul 5 2018, 3:10 PM
gabriel-wmde mentioned this in rEASR930ecc535c7f: Preselect first item when searching for namespace.Jul 5 2018, 3:13 PM
Lea_WMDE added a project: WMDE-FUN-Sprint-2018-07-09.Jul 9 2018, 10:03 AM
Lea_WMDE changed the point value for this task from 1 to 0.
Lea_WMDE moved this task from Todo to Blocked externally on the WMDE-FUN-Sprint-2018-07-09 board.
gerritbot added a comment.Jul 9 2018, 8:01 PM

Change 443989 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Preselect first item when searching for namespace

https://gerrit.wikimedia.org/r/443989

gabriel-wmde moved this task from Blocked externally to Test on the WMDE-FUN-Sprint-2018-07-09 board.Jul 20 2018, 8:12 AM
gabriel-wmde mentioned this in rEASR40f1c277a9da: Always preselect first item in namespace drop-down.Jul 20 2018, 9:49 AM
Lea_WMDE moved this task from Test to Done on the WMDE-FUN-Sprint-2018-07-09 board.Jul 20 2018, 12:49 PM
Lea_WMDE closed this task as Resolved.Jul 31 2018, 11:56 AM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 2:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL