Maniphest T190344

Crash when attempting to parse SiteMatrix data
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	• Mholloway
	Mar 21 2018, 9:09 PM

Description

Steps to reproduce

Open the app
Tap the search bar to open the search fragment
Tap the language selector button

Stack trace

FATAL EXCEPTION: main
Process: org.wikipedia.dev, PID: 2470
com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was BEGIN_ARRAY at path $
     at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:224)
     at org.wikipedia.json.PostProcessingTypeAdapter$1.read(PostProcessingTypeAdapter.java:26)
     at com.google.gson.Gson.fromJson(Gson.java:887)
     at com.google.gson.Gson.fromJson(Gson.java:952)
     at com.google.gson.Gson.fromJson(Gson.java:925)
     at org.wikipedia.language.SiteMatrixClient$1.onResponse(SiteMatrixClient.java:49)
     at retrofit2.ExecutorCallAdapterFactory$ExecutorCallbackCall$1$1.run(ExecutorCallAdapterFactory.java:70)
     at android.os.Handler.handleCallback(Handler.java:790)
     at android.os.Handler.dispatchMessage(Handler.java:99)
     at android.os.Looper.loop(Looper.java:164)
     at android.app.ActivityThread.main(ActivityThread.java:6494)
     at java.lang.reflect.Method.invoke(Native Method)
     at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
  Caused by: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was BEGIN_ARRAY at path $
     at com.google.gson.internal.bind.JsonTreeReader.expect(JsonTreeReader.java:162)
     at com.google.gson.internal.bind.JsonTreeReader.beginObject(JsonTreeReader.java:87)
     at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:213)
     at org.wikipedia.json.PostProcessingTypeAdapter$1.read(PostProcessingTypeAdapter.java:26) 
     at com.google.gson.Gson.fromJson(Gson.java:887) 
     at com.google.gson.Gson.fromJson(Gson.java:952) 
     at com.google.gson.Gson.fromJson(Gson.java:925) 
     at org.wikipedia.language.SiteMatrixClient$1.onResponse(SiteMatrixClient.java:49) 
     at retrofit2.ExecutorCallAdapterFactory$ExecutorCallbackCall$1$1.run(ExecutorCallAdapterFactory.java:70) 
     at android.os.Handler.handleCallback(Handler.java:790) 
     at android.os.Handler.dispatchMessage(Handler.java:99) 
     at android.os.Looper.loop(Looper.java:164) 
     at android.app.ActivityThread.main(ActivityThread.java:6494) 
     at java.lang.reflect.Method.invoke(Native Method) 
     at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438) 
     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

Environments observed

App version: dev
Android OS versions: O
Device model: Nexus 6P
Device language: en

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Prevent possible crash when parsing SiteMatrix response.	apps/android/wikipedia	master	+18 -14

Customize query in gerrit

Event Timeline

• Mholloway created this task.Mar 21 2018, 9:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2018, 9:09 PM

• Mholloway updated the task description. (Show Details)Mar 21 2018, 9:10 PM

What was your current wiki language before tapping the selector?

It was German.

Change 421180 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Prevent possible crash when parsing SiteMatrix response.

https://gerrit.wikimedia.org/r/421180

gerritbot added a project: Patch-For-Review.Mar 21 2018, 9:34 PM

Change 421180 merged by jenkins-bot:
[apps/android/wikipedia@master] Prevent possible crash when parsing SiteMatrix response.

https://gerrit.wikimedia.org/r/421180

Dbrant moved this task from Needs Triage to Android-app-release-v2.7.24x-H-Hot-pepper on the Wikipedia-Android-App-Backlog board.Mar 22 2018, 12:32 PM

Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper); removed Wikipedia-Android-App-Backlog.

Restricted Application edited projects, added Wikipedia-Android-App-Backlog; removed Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper). · View Herald TranscriptMar 22 2018, 12:32 PM

Dbrant moved this task from Needs Triage to Android-app-release-v2.7.24x-H-Hot-pepper on the Wikipedia-Android-App-Backlog board.Mar 22 2018, 12:32 PM

Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper); removed Wikipedia-Android-App-Backlog.

Dbrant claimed this task.Mar 22 2018, 12:47 PM

Dbrant moved this task from Backlog to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.