| Samwilson | |
| Mar 22 2018, 1:33 AM |
| F16392046: Screen Shot 2018-03-28 at 4.53.05 PM.png | |
| Mar 28 2018, 11:53 PM |
| F15954800: Screenshot-2018-3-22 Editing Main Page - Dev Wiki wiki1.png | |
| Mar 22 2018, 1:33 AM |
The CodeMirror icon has a border on its right-hand side
This is because it is in a new toolbar group all on its own. WikiEditor thinks the 'tools' group is the last one, and removes its border (so that none appears before the arrow for 'Advanced'):
.wikiEditor-ui-toolbar .group-insert {
border-right: 0;
}Maybe this is something WikiEditor should handle? It does after all decide where the new group gets inserted and so could change how it handles the border-removing.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Hide right border of only the last group in the toolbar | mediawiki/extensions/WikiEditor | master | +4 -4 |
Hmm, maybe. It's not a big deal. We should do it if it seems like it'll be pretty simple. Let's discuss this in estimation.
Change 423042 had a related patch set uploaded (by MusikAnimal; owner: MusikAnimal):
[mediawiki/extensions/WikiEditor@master] Hide right border of only the last group in the toolbar
Change 423042 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Hide right border of only the last group in the toolbar
