Page MenuHomePhabricator

Account creation page says "-1 recent contributors"
Closed, DuplicatePublic

Description

Reported from a 3rd party wiki running MediaWiki 1.23.6.

The default values for the ss_active_users, ss_total_pages, and ss_users fields are -1, while the other site stat fields have a default value of 0. Regardless of whether this makes sense or not, we should probably prevent showing "-1 recent contributors" to prospective new editors, lol.

Details

Related Gerrit Patches:

Event Timeline

kaldari created this task.Mar 23 2018, 2:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2018, 2:27 AM

Change 421470 had a related patch set uploaded (by Kaldari; owner: Kaldari):
[mediawiki/core@master] Making sure that stats aren't "-1" before showing to users.

https://gerrit.wikimedia.org/r/421470

The solution I created only addresses the issue in this one particular interface, since it may be useful to surface the "-1" in other interfaces like Special:Statistics to let admins know that something isn't working.

kaldari updated the task description. (Show Details)Mar 23 2018, 2:39 AM

The main issue of this task and T56888 was fixed by https://gerrit.wikimedia.org/r/349770 in master during development of 1.30.0-alpha development, backported to REL1_29. It has since been released as part of both 1.29.0 and 1.30.0.

Change 421470 abandoned by Kaldari:
Making sure that stats aren't "-1" before showing to users.

Reason:
Per Krinkle

https://gerrit.wikimedia.org/r/421470

Wow, I'm amazed that we had such a glaring bug for 4 years!