Maniphest T190494

Namespace filter missing for advanced search on beta.wmflabs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Schnark
	Mar 23 2018, 8:20 AM

Description

Go to https://de.wikipedia.beta.wmflabs.org/wiki/Spezial:Einstellungen#mw-prefsection-betafeatures, enable advanced search.
Go to https://de.wikipedia.beta.wmflabs.org/w/index.php?search=&title=Spezial%3ASuche&go=Artikel

Expected: Namespace filter is shown.
Actual: Namespace filter is missing, error console shows an error "Too much recursion", with a stack trace that looks line an infinite loop of

OO.ui.mixin.GroupElement.prototype.addItems
OO.ui.TagMultiselectWidget.prototype.onTagDisabled
oo.EventEmitter.prototype.emit
oo.EventEmitter.prototype.emit
OO.ui.TagItemWidget.prototype.setDisabled
mw.libs.advancedSearch.ui.NamespaceFilters.prototype.onChangeTags
oo.EventEmitter.prototype.emit

Related Objects

Mentioned In: T190307: Cannot find module nodemw
Mentioned Here: T189130: Allow an empty namespace bar
rGOJUaca140acaf80: TagMultiselectWidget: Handle disabled items

Event Timeline

Schnark created this task.Mar 23 2018, 8:20 AM

Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptMar 23 2018, 8:20 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Might be caused by rGOJUaca140acaf80: TagMultiselectWidget: Handle disabled items, which could infer with the code that disables the namespace tags if there is only one left.

Thanks for looking into it Schnark! FYI, for AdvancedSearch, we are getting rid of the disabled tags as of T189130: Allow an empty namespace bar, but that doesn't stop this from being a bug anyways... @Volker_E @Mooeypoo @matmarex in case this has something to do with your current rollout

thiemowmde mentioned this in T190307: Cannot find module nodemw.Mar 23 2018, 11:54 AM

In a user script, where the same issue occurred, I fixed it by simply replacing onTagDisabled with a dummy: https://de.wikipedia.org/w/index.php?title=Benutzer:Schnark/js/fliegelflagel.js/manage.js&diff=prev&oldid=175336216

I think this magically resolved itself with the changes we did for T189130. @Schnark, can you please check if the error is gone now?

matmarex removed a project: OOUI.Apr 5 2018, 5:43 PM

matmarex unsubscribed.

I'm setting this as resolved since we did not hear anything after the last changes. If this issue still persists, please reopen.

Lea_WMDE moved this task from Backlog to In FUN sprint on the Advanced-Search board.Dec 4 2018, 9:04 AM

Namespace filter missing for advanced search on beta.wmflabsClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Namespace filter missing for advanced search on beta.wmflabs
Closed, ResolvedPublic
Actions