Page MenuHomePhabricator
Create Task
Maniphest T190581

Clarify 'settings' and 'advanced' icon names
Closed, ResolvedPublic
Actions

Description

As of v.0.26.0 'settings' and 'advanced' icon are confusingly named to OOUI developers and with the new icon set also signify slightly different use case.
We should rename it to 'pageSettings' and 'settings'. Related: T190175

Due to naming conflict, we'll have to do it in sequences:

  • Rename filenames used for 'settings'
  • Add 'pageSettings'
    • and add 'settings' to same icon packs
  • Replace usage of 'settings' with 'pageSettings'
    • OOUI toolbar 'settings' here is only in documentation; the current 'advanced' which will be to the correct 'settings'
    • VE at modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
    • VE at modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js T202101

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Volker_E created this task.Mar 23 2018, 9:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2018, 9:51 PM
Volker_E mentioned this in T190175: Fix page settings/advanced settings icons.Mar 23 2018, 9:52 PM
Esanders mentioned this in T191099: Options inside Basic reference dialog and Categories are using the same icon as Page Settings .Apr 4 2018, 12:12 PM
Volker_E moved this task from Backlog to Next-up on the OOUI board.Apr 9 2018, 7:11 PM
Volker_E updated the task description. (Show Details)May 7 2018, 10:54 PM
gerritbot subscribed.May 7 2018, 11:25 PM

Change 431677 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] [DEPRECATING CHANGE] icons: Rename 'settings' to 'pageSettings'

https://gerrit.wikimedia.org/r/431677

gerritbot added a project: Patch-For-Review.May 7 2018, 11:25 PM
Volker_E updated the task description. (Show Details)May 7 2018, 11:34 PM
Volker_E moved this task from Next-up to Doing on the OOUI board.
gerritbot added a comment.May 8 2018, 4:02 PM

Change 431677 merged by jenkins-bot:
[oojs/ui@master] [DEPRECATING CHANGE] icons: Rename 'settings' to 'pageSettings'

https://gerrit.wikimedia.org/r/431677

Volker_E updated the task description. (Show Details)May 22 2018, 6:42 PM
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)May 22 2018, 6:52 PM
Volker_E updated the task description. (Show Details)May 22 2018, 10:55 PM
gerritbot added a comment.Aug 13 2018, 6:20 PM

Change 452445 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[oojs/ui@master] [BREAKING CHANGE] icons: Drop 'settings' icon, deprecated in v0.27.0

https://gerrit.wikimedia.org/r/452445

gerritbot added a comment.Aug 13 2018, 9:21 PM

Change 452445 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] icons: Drop 'settings' icon, deprecated in v0.27.0

https://gerrit.wikimedia.org/r/452445

gerritbot added a comment.Aug 15 2018, 12:09 AM

Change 452872 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.28.0

https://gerrit.wikimedia.org/r/452872

gerritbot added a comment.Aug 15 2018, 5:56 PM

Change 452872 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.28.0

https://gerrit.wikimedia.org/r/452872

Jdforrester-WMF edited projects, added: MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed: Patch-For-Review.Aug 15 2018, 7:24 PM

The OOUI release landed in MediaWiki 1.32.0-wmf.18.

Volker_E updated the task description. (Show Details)Aug 16 2018, 11:34 PM
Volker_E updated the task description. (Show Details)Aug 16 2018, 11:43 PM
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Aug 16 2018, 11:46 PM

Change 453304 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] demos: Use renamed 'pageSettings' icon

https://gerrit.wikimedia.org/r/453304

gerritbot added a project: Patch-For-Review.Aug 16 2018, 11:46 PM
gerritbot added a comment.Aug 16 2018, 11:56 PM

Change 453304 merged by jenkins-bot:
[oojs/ui@master] demos: Use renamed 'pageSettings' icon

https://gerrit.wikimedia.org/r/453304

gerritbot added a comment.Aug 17 2018, 12:00 AM

Change 453306 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/VisualEditor@master] Replace 'settings' by renamed 'pageSettings' icon

https://gerrit.wikimedia.org/r/453306

Volker_E updated the task description. (Show Details)Aug 17 2018, 12:13 AM
gerritbot added a comment.Aug 17 2018, 12:28 AM

Change 453306 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Replace 'settings' by renamed 'pageSettings' icon

https://gerrit.wikimedia.org/r/453306

gerritbot added a comment.Aug 21 2018, 8:09 PM

Change 454363 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] [DEPRECATING CHANGE]: icons: Rename 'advanced' to 'settings'

https://gerrit.wikimedia.org/r/454363

Volker_E updated the task description. (Show Details)Aug 21 2018, 9:20 PM
Volker_E moved this task from Doing to Waiting for breaking release on the OOUI board.Aug 21 2018, 9:31 PM
Volker_E triaged this task as Medium priority.Sep 5 2018, 6:20 PM
gerritbot added a comment.Sep 5 2018, 11:12 PM

Change 454363 merged by jenkins-bot:
[oojs/ui@master] [DEPRECATING CHANGE]: icons: Rename 'advanced' to 'settings'

https://gerrit.wikimedia.org/r/454363

Volker_E updated the task description. (Show Details)Sep 8 2018, 2:33 AM
gerritbot added a comment.Sep 8 2018, 2:38 AM

Change 458984 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] RCFilters: Replace deprecated 'advanced' by renamed to 'settings' icon

https://gerrit.wikimedia.org/r/458984

gerritbot added a comment.Sep 8 2018, 2:46 AM

Change 458988 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/VisualEditor@master] Replace deprecated 'advanced' by renamed to 'settings' icon

https://gerrit.wikimedia.org/r/458988

gerritbot added a comment.Sep 8 2018, 2:51 AM

Change 458991 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/ContentTranslation@master] Replace deprecated 'advanced' by renamed to 'settings' icon

https://gerrit.wikimedia.org/r/458991

gerritbot added a comment.Sep 8 2018, 2:57 AM

Change 458992 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Echo@master] Replace deprecated 'advanced' by renamed to 'settings' icon

https://gerrit.wikimedia.org/r/458992

gerritbot added a comment.Sep 8 2018, 3:00 AM

Change 458993 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Cite@master] Replace deprecated 'advanced' by renamed to 'settings' icon

https://gerrit.wikimedia.org/r/458993

gerritbot added a comment.Sep 8 2018, 3:06 AM

Change 458997 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/TemplateData@master] Replace deprecated 'advanced' by renamed to 'settings' icon

https://gerrit.wikimedia.org/r/458997

Volker_E updated the task description. (Show Details)Sep 8 2018, 3:07 AM
gerritbot added a comment.Sep 12 2018, 12:33 AM

Change 459879 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.28.2

https://gerrit.wikimedia.org/r/459879

gerritbot added a comment.Sep 12 2018, 1:09 AM

Change 459879 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.28.2

https://gerrit.wikimedia.org/r/459879

gerritbot added a comment.Sep 12 2018, 4:23 PM

Change 458997 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Replace deprecated 'advanced' by renamed to 'settings' icon

https://gerrit.wikimedia.org/r/458997

gerritbot added a comment.Sep 12 2018, 4:45 PM

Change 458991 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Replace deprecated 'advanced' by renamed to 'settings' icon

https://gerrit.wikimedia.org/r/458991

gerritbot added a comment.Sep 12 2018, 4:45 PM

Change 458992 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Replace deprecated 'advanced' by renamed to 'settings' icon

https://gerrit.wikimedia.org/r/458992

gerritbot added a comment.Sep 12 2018, 4:47 PM

Change 458993 merged by Jforrester:
[mediawiki/extensions/Cite@master] Replace deprecated 'advanced' by renamed to 'settings' icon

https://gerrit.wikimedia.org/r/458993

gerritbot added a comment.Sep 12 2018, 4:49 PM

Change 458984 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Replace deprecated 'advanced' by renamed to 'settings' icon

https://gerrit.wikimedia.org/r/458984

ReleaseTaggerBot edited projects, added: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)); removed: MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).Sep 12 2018, 5:00 PM
gerritbot added a comment.Sep 12 2018, 5:26 PM

Change 458988 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Replace deprecated 'advanced' by renamed to 'settings' icon

https://gerrit.wikimedia.org/r/458988

gerritbot added a comment.Sep 12 2018, 7:50 PM

Change 460087 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/TemplateData@master] Replace deprecated 'advanced' by renamed to 'settings' icon

https://gerrit.wikimedia.org/r/460087

gerritbot added a comment.Sep 12 2018, 8:05 PM

Change 460087 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Replace deprecated 'advanced' by renamed to 'settings' icon

https://gerrit.wikimedia.org/r/460087

Volker_E removed a project: Patch-For-Review.Sep 12 2018, 8:12 PM
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Sep 12 2018, 8:18 PM

Change 460091 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] [BREAKING CHANGE] icons: Drop 'advanced' icon, deprecated in v0.28.1

https://gerrit.wikimedia.org/r/460091

gerritbot added a project: Patch-For-Review.Sep 12 2018, 8:18 PM
Volker_E updated the task description. (Show Details)Sep 12 2018, 8:18 PM
gerritbot added a comment.Dec 20 2018, 3:54 AM

Change 460091 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] icons: Drop 'advanced' icon, deprecated in v0.28.1

https://gerrit.wikimedia.org/r/460091

gerritbot added a comment.Dec 22 2018, 11:37 AM

Change 481239 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.30.0

https://gerrit.wikimedia.org/r/481239

gerritbot added a comment.Dec 24 2018, 1:51 AM

Change 481239 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.30.0

https://gerrit.wikimedia.org/r/481239

Jdforrester-WMF closed this task as Resolved.Jan 1 2019, 4:04 PM
Jdforrester-WMF edited projects, added: MW-1.33-notes (1.33.0-wmf.12; 2019-01-08); removed: Patch-For-Review.
Jdforrester-WMF updated the task description. (Show Details)
stjn mentioned this in T225873: Infinite scroll in StructuredDiscussions has no loading icon.Jun 15 2019, 7:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits