Page MenuHomePhabricator
Create Task
Maniphest T190583

UploadWizard uses php-intl without checking for availability
Closed, ResolvedPublic
Actions

Description

It seems that UploadWizard unconditionally uses the php-intl Collator

Since intl isn't a hard dependency, because the default of wgCategoryCollation is still the simple 'uppercase' collator and since it's not listed as a requirement for UW in either composer.json nor in its documentation, i think we should correct this.

Introduced in change-id I35313fc3e41a4b26634f7c13bfb708bd04995100

Event Timeline

TheDJ created this task.Mar 23 2018, 10:02 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptMar 23 2018, 10:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a subscriber: gerritbot.Mar 28 2018, 2:15 PM

Change 422411 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/UploadWizard@master] Check if Collator is available before using it

https://gerrit.wikimedia.org/r/422411

matmarex claimed this task.Mar 28 2018, 2:15 PM
matmarex triaged this task as Low priority.
Ramsey-WMF moved this task from Untriaged to Tracking on the Multimedia board.Mar 28 2018, 5:07 PM
gerritbot added a comment.Mar 28 2018, 7:25 PM

Change 422411 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Check if Collator is available before using it

https://gerrit.wikimedia.org/r/422411

matmarex closed this task as Resolved.Mar 28 2018, 7:33 PM
matmarex removed a project: Patch-For-Review.
TheDJ awarded a token.Mar 28 2018, 9:10 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL