Maniphest T190591

Dialog asking "Do you really want to abandon your edit?" appears while saving an edit with mobile VE
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ryasmeen
	Mar 23 2018, 10:49 PM

Description

Dialog asking "Do you really want to abandon your edit?" appears very briefly while saving an edit with mobile VE

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	VisualEditorOverlay: don't show leave-confirm dialog after saving	mediawiki/extensions/MobileFrontend	master	+6 -1

Customize query in gerrit

Event Timeline

Ryasmeen created this task.Mar 23 2018, 10:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2018, 10:49 PM

I can't reproduce this. Can you give more details?

Okay, so this is reproducible in Chrome and Firefox but not in Safari. I am getting this error every time I try to save an edit. Video capture attached if that helps:

Abandon.mov1 MBDownload

Ryasmeen changed the task status from Stalled to Open.Mar 29 2018, 10:16 PM

Change 434014 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/MobileFrontend@master] VisualEditorOverlay: don't show leave-confirm dialog after saving

https://gerrit.wikimedia.org/r/434014

gerritbot added a project: Patch-For-Review.May 19 2018, 3:44 PM

DLynch claimed this task.May 20 2018, 10:55 AM

DLynch edited projects, added VisualEditor (Current work); removed VisualEditor.

DLynch moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Change 434014 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] VisualEditorOverlay: don't show leave-confirm dialog after saving

https://gerrit.wikimedia.org/r/434014

Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.May 20 2018, 5:30 PM

Jdforrester-WMF edited projects, added VisualEditor-MediaWiki, VisualEditor-MediaWiki-Media; removed Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)).May 20 2018, 6:00 PM

• Deskana closed this task as Resolved.May 23 2018, 3:36 PM

• Deskana triaged this task as Medium priority.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 23 2018, 3:36 PM

Ryasmeen added projects: Verified, Verified-in-Phase0.May 24 2018, 10:29 PM

	F16267861: Abandon.mov
	Mar 27 2018, 9:39 PM

Dialog asking "Do you really want to abandon your edit?" appears while saving an edit with mobile VEClosed, ResolvedPublicActions

Description

Details

Event Timeline

Dialog asking "Do you really want to abandon your edit?" appears while saving an edit with mobile VE
Closed, ResolvedPublic
Actions