Page MenuHomePhabricator

"View changes" link for bundled notices about board description editing should show all changes
Open, Needs TriagePublic

Description

Hello. Here is the process:

  1. User A has flow board M in whatchlist on wiki X.
  2. User A logs out, for example.
  3. User B edits the description of M.
  4. User C edits the description of M.
  5. User A logs in on different wiki Y.
  6. User A gets a bundle notification "the description of M on wiki X was edited a few times".
  7. User A clicks on "..." in the bundle.
  8. User A clicks on "view diff".
  9. User A gets a diff for C edit only - it not includes also B edit as expected.

Thank you.

Event Timeline

IKhitron created this task.Mar 24 2018, 2:31 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 24 2018, 2:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Etonkovidova added a subscriber: Etonkovidova.EditedMar 29 2018, 8:08 PM

@IKhitron Following the steps you described, clicking on "view diff" presented me with diff for both edits (tested in betalabs).

My steps:
(1) ET2 and ET3 edited board description of a board watched by ET1 on enwiki
(2) ET1 logs in to hewiki and sees


(3) Clicking on 'View changes', ET1 will be taken to enwiki to see both edits made by ET2 and ET3

(4) After that, the bundled notifications become unbundled and marked as read. If now ET1 clicks to "View changes", the diff will be shown only for that particular change.

@IKhitron Following the steps you described, clicking on "view diff" presented me with diff for both edits (tested in betalabs).

Hello, Etonkovidova. As I can see, you get exactly the same problem. Your middle screenshot shows a diff that includes only one edit, of ET3, when the edit of ET2 appears as diff base. If it works well, you could see some previous edit as diff base, and message "one edit of another user is not shown", as it always happens in version diffs.

Comparing the options for bundled notifications, I noticed that only the board description bundled notices have "View change" link:

Probably, we need to make bundled notices consistent in terms of links presented in notices. I've updated the title - the issue is not specific to crosswiki notifications.

Etonkovidova renamed this task from Interwiki bundle notice about description editings provides wrong link to "View changes" link for bundled notices about board description editing should show all changes .Apr 3 2018, 12:47 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 3 2018, 5:57 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 19 2018, 11:29 AM