Closing mobile VE doesn't abandon auto save
Open, NormalPublic1 Story Points

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2018, 11:40 PM
Esanders set the point value for this task to 1.

Change 421910 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] Override tryTeardown instead of close

https://gerrit.wikimedia.org/r/421910

Deskana triaged this task as Normal priority.Mar 26 2018, 4:13 PM

Change 421910 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Override tryTeardown instead of close

https://gerrit.wikimedia.org/r/421910

Ryasmeen added a subscriber: Ryasmeen.EditedMar 28 2018, 12:04 AM

I understand the above patch fixes the case where a user clicks the back button inside mobile VE?
But, there is another case where this is still happening. When a user clicks the browser back button, it shows a dialog explicitly asking "Do you really want to abandon the edit? ". But even if you click "OK", reopening VE shows the recovered edit. Shouldn't it discard the edit as well?

Change 445444 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] Allow hide to return a promise and handle teardown

https://gerrit.wikimedia.org/r/445444

Esanders moved this task from To Triage to Current work on the VisualEditor board.Thu, Jul 12, 5:54 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.