Page MenuHomePhabricator
Create Task
Maniphest T190694

With narrow toolbar, icons in dropdown menus are broken
Closed, ResolvedPublic
Actions

Description

With narrow toolbar, icons in dropdown menus are broken.

image.png (943×1 px, 138 KB)

Probably a regression in OOUI v0.26.1.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (d136c58c0)mediawiki/extensions/VisualEditormaster+1 -1
Revert "Workaround for WikimediaUI theme broken tool icons in popup toolgroups"VisualEditor/VisualEditormaster+1 -7
Workaround for WikimediaUI theme broken tool icons in popup toolgroupsVisualEditor/VisualEditormaster+6 -0
Update VE core submodule to master (28a9de285)mediawiki/extensions/VisualEditormaster+1 -1
WikimediaUI theme: Fix tool icons in popup toolgroupsoojs/uimaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

matmarex triaged this task as Unbreak Now! priority.Mar 26 2018, 4:04 PM
matmarex created this task.
Restricted Application added subscribers: Liuxinyu970226, TerraCodes, Aklapper. · View Herald TranscriptMar 26 2018, 4:04 PM
• Elitre awarded a token.Mar 26 2018, 4:09 PM
gerritbot subscribed.Mar 26 2018, 4:45 PM

Change 421944 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] WikimediaUI theme: Fix tool icons in popup toolgroups

https://gerrit.wikimedia.org/r/421944

gerritbot added a project: Patch-For-Review.Mar 26 2018, 4:45 PM
gerritbot added a comment.Mar 26 2018, 4:49 PM

Change 421945 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] Workaround for WikimediaUI theme broken tool icons in popup toolgroups

https://gerrit.wikimedia.org/r/421945

gerritbot added a comment.Mar 26 2018, 4:55 PM

Change 421945 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Workaround for WikimediaUI theme broken tool icons in popup toolgroups

https://gerrit.wikimedia.org/r/421945

gerritbot added a comment.Mar 26 2018, 5:03 PM

Change 421944 merged by jenkins-bot:
[oojs/ui@master] WikimediaUI theme: Fix tool icons in popup toolgroups

https://gerrit.wikimedia.org/r/421944

gerritbot added a comment.Mar 26 2018, 6:03 PM

Change 421959 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (28a9de285)

https://gerrit.wikimedia.org/r/421959

gerritbot added a comment.Mar 26 2018, 6:21 PM

Change 421959 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (28a9de285)

https://gerrit.wikimedia.org/r/421959

Jdforrester-WMF edited projects, added VisualEditor-EditingTools, VisualEditor (Current work); removed Patch-For-Review, VisualEditor.Mar 26 2018, 6:29 PM
Jdforrester-WMF moved this task from Incoming to Product owner review on the VisualEditor (Current work) board.
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)).Mar 26 2018, 7:00 PM
Volker_E closed this task as Resolved.Mar 27 2018, 1:00 AM
Volker_E moved this task from Backlog to Reviewing on the OOUI board.
Volker_E moved this task from Reviewing to OOUI-0.26.2 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.26.2); removed OOUI.
Liuxinyu970226 unsubscribed.Mar 27 2018, 6:47 AM
gerritbot added a comment.Apr 4 2018, 6:06 PM

Change 424022 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] Revert "Workaround for WikimediaUI theme broken tool icons in popup toolgroups"

https://gerrit.wikimedia.org/r/424022

gerritbot added a project: Patch-For-Review.Apr 4 2018, 6:06 PM
gerritbot added a comment.Apr 4 2018, 6:15 PM

Change 424022 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Revert "Workaround for WikimediaUI theme broken tool icons in popup toolgroups"

https://gerrit.wikimedia.org/r/424022

gerritbot added a comment.Apr 5 2018, 12:55 AM

Change 424177 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d136c58c0)

https://gerrit.wikimedia.org/r/424177

gerritbot added a comment.Apr 5 2018, 1:27 AM

Change 424177 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d136c58c0)

https://gerrit.wikimedia.org/r/424177

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)); removed MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)).Apr 5 2018, 2:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL