I think there is a mistake on MediaWiki:Apihelp-readinglists+createentry-example-1: The closing tag </kbd> is missing.
Description
Details
Related Objects
- Mentioned In
- rERLS0ea3d87e3b5d: Fix close tag for [[MediaWiki:Apihelp-readinglists+createentry-example-1]].
rERLS463045848a81: Fix close tag for [[MediaWiki:Apihelp-readinglists+createentry-example-1]].
rERLS4359852b0e2d: Fix close tag for [[MediaWiki:Apihelp-readinglists+createentry-example-1]].
rERLSc8e5990f9dfa: Fix close tag for [[MediaWiki:Apihelp-readinglists+createentry-example-1]].
Event Timeline
@Guycn2: See https://www.mediawiki.org/wiki/Gerrit/Tutorial for some info. Happy hacking! :)
Thank you. But I'm stuck... When I type "$ ls ~/.ssh" on Git CMD, I get the following error message:
'$1' is not recognized as an internal or external command, operable program or batch file.
@Guycn2: I've updated the guide. Please feel free to ask general Gerrit support questions (not directly related to this task's topic) on the talk page. Thanks!
@Aklapper: Thank you, but unfortunately I still get the same error message, even without the dollar sign. Anyway, I will ask on the talk page soon, but I think it's better if you or Tgr will write this specific patch... Thanks again.
You can create patches via the web interface using the Create Change button on https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/ReadingLists . Not sure if it's much easier (Gerrit's UI leaves a lot to wish for) but might be worth a shot.
@Tgr I think I have succeeded! Could you please check it to make sure I haven't done anything worng?
The patch is here:
https://gerrit.wikimedia.org/r/#/c/423177/
The patch is correct, but it should be against the master branch, not wmf/1.31.0-wmf.27.
Also, you can add
Bug: T190786
in the commit summary (just above the change ID line) to link the commit to this task.
@Tgr
Done, thank you so much for your help! I have two questions:
- When will this change take affect on Wikimedia wikis?
- How can I determine which branch is the appropriate one for each patch? I ask so I can know for future patches that I'll write...
- After the patch gets a "+2" by a reviewer and gets merged, it will go live within a week.
- master is always the Git branch to target as it will become the next deployed version. If it's an important change it could be backported to a different branch.
Thanks for your patch! :)
Change 423184 had a related patch set uploaded (by Gergő Tisza; owner: Guycn2):
[mediawiki/extensions/ReadingLists@master] Fix close tag for [[MediaWiki:Apihelp-readinglists+createentry-example-1]].
Change 423184 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] Fix close tag for [[MediaWiki:Apihelp-readinglists+createentry-example-1]].