Page MenuHomePhabricator
Create Task
Maniphest T190826

Improve code coverage of Importer
Closed, DuplicatePublic3 Estimated Story Points
Actions

Description

Importer is technically part of SpecialImportFile::doImport() and could be tested via SpecialImportFileIntegrationTest, but currently isn't. It would basically be an integration test

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Test unedited/edited requests separately in ImporterComponentTestmediawiki/extensions/FileImportermaster+46 -10
Add ImporterComponentTest case for 1 file revisionmediawiki/extensions/FileImportermaster+111 -25
Add ImporterComponentTestmediawiki/extensions/FileImportermaster+208 -1
Introduce WikiPageFactory to make Importer testablemediawiki/extensions/FileImportermaster+39 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Lea_WMDE created this task.Mar 27 2018, 3:21 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptMar 27 2018, 3:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Lea_WMDE triaged this task as Medium priority.Mar 27 2018, 3:22 PM
• Lea_WMDE updated the task description. (Show Details)
• Lea_WMDE set the point value for this task to 3.
• Lea_WMDE moved this task from Tickets in preparation/investigation to Tickets ready for pickup on the Move-Files-To-Commons board.
thiemowmde mentioned this in T190290: Reach a stable test coverage for the FileImporter PHP code.Mar 27 2018, 3:39 PM
thiemowmde added a parent task: T190290: Reach a stable test coverage for the FileImporter PHP code.Apr 11 2018, 5:28 PM
thiemowmde moved this task from Incoming to Move files to Commons on the TCB-Team (now WMDE-TechWish) board.May 11 2018, 5:06 PM
thiemowmde added a project: Test-Coverage.Jun 12 2018, 4:38 PM
• Lea_WMDE closed this task as a duplicate of T197681: Add integration test covering import functionality in core.Jul 3 2018, 1:10 PM
gerritbot subscribed.Jul 5 2018, 4:58 PM

Change 444023 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Add ImporterComponentTest

https://gerrit.wikimedia.org/r/444023

gerritbot added a project: Patch-For-Review.Jul 5 2018, 4:58 PM
thiemowmde mentioned this in rEFLI95652c3116ef: Add ImporterComponentTest.Jul 5 2018, 4:59 PM
gerritbot added a comment.Jul 5 2018, 5:42 PM

Change 444033 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Add ImporterComponentTest case for 1 file revision

https://gerrit.wikimedia.org/r/444033

thiemowmde mentioned this in rEFLIfd8556afc817: Add ImporterComponentTest case for 1 file revision.Jul 5 2018, 5:42 PM
gerritbot added a comment.Jul 6 2018, 8:18 AM

Change 444168 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Introduce WikiPageFactory to make Importer testable

https://gerrit.wikimedia.org/r/444168

thiemowmde mentioned this in rEFLI19d28ab5d758: Introduce WikiPageFactory to make Importer testable.Jul 6 2018, 8:20 AM
thiemowmde mentioned this in rEFLI3935d02066f9: Introduce WikiPageFactory to make Importer testable.Jul 6 2018, 8:27 AM
thiemowmde mentioned this in rEFLI0bfa82e2a4c6: Add ImporterComponentTest.Jul 6 2018, 8:41 AM
thiemowmde mentioned this in rEFLIe02a75d5d0d8: Add ImporterComponentTest case for 1 file revision.Jul 6 2018, 8:52 AM
thiemowmde mentioned this in rEFLI8e515374090d: Add ImporterComponentTest case for 1 file revision.Jul 6 2018, 9:33 AM
gerritbot added a comment.Jul 6 2018, 10:05 AM

Change 444189 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Test unedited/edited requests separately in ImporterComponentTest

https://gerrit.wikimedia.org/r/444189

thiemowmde mentioned this in rEFLI1cfb36d61552: Test unedited/edited requests separately in ImporterComponentTest.Jul 6 2018, 10:05 AM
thiemowmde mentioned this in rEFLI1fca19116f8b: Test unedited/edited requests separately in ImporterComponentTest.Jul 9 2018, 8:58 AM
gerritbot added a comment.Jul 11 2018, 12:24 PM

Change 444168 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Introduce WikiPageFactory to make Importer testable

https://gerrit.wikimedia.org/r/444168

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)).Jul 11 2018, 1:00 PM
Andrew-WMDE mentioned this in rEFLIf6a9bc459171: Add ImporterComponentTest.Jul 11 2018, 1:23 PM
Andrew-WMDE mentioned this in rEFLI94209ab3b0ed: Add ImporterComponentTest.Jul 11 2018, 2:01 PM
Andrew-WMDE mentioned this in rEFLI93141d052e86: Add ImporterComponentTest.Jul 11 2018, 2:04 PM
Andrew-WMDE mentioned this in rEFLI51a51333f7cb: Add ImporterComponentTest.Jul 11 2018, 2:11 PM
Andrew-WMDE mentioned this in rEFLI7f675160853e: Add ImporterComponentTest case for 1 file revision.Jul 11 2018, 3:28 PM
Andrew-WMDE mentioned this in rEFLI9fa55335a712: Test unedited/edited requests separately in ImporterComponentTest.Jul 11 2018, 3:50 PM
gerritbot added a comment.Jul 11 2018, 4:38 PM

Change 444023 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Add ImporterComponentTest

https://gerrit.wikimedia.org/r/444023

thiemowmde mentioned this in rEFLI9b234440149c: Add ImporterComponentTest case for 1 file revision.Jul 15 2018, 8:56 AM
gerritbot added a comment.Jul 16 2018, 8:48 AM

Change 444033 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Add ImporterComponentTest case for 1 file revision

https://gerrit.wikimedia.org/r/444033

WMDE-Fisch mentioned this in rEFLId51fb7558ca2: Test unedited/edited requests separately in ImporterComponentTest.Jul 16 2018, 10:18 AM
gerritbot added a comment.Jul 16 2018, 10:25 AM

Change 444189 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Test unedited/edited requests separately in ImporterComponentTest

https://gerrit.wikimedia.org/r/444189

• Lea_WMDE moved this task from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.Aug 29 2018, 3:55 PM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 2:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits