Page MenuHomePhabricator

Improve code coverage of Importer
Closed, DuplicatePublic3 Estimated Story Points

Description

Importer is technically part of SpecialImportFile::doImport() and could be tested via SpecialImportFileIntegrationTest, but currently isn't. It would basically be an integration test

Event Timeline

Lea_WMDE created this task.Mar 27 2018, 3:21 PM
Restricted Application added a project: archived--TCB-Team. · View Herald TranscriptMar 27 2018, 3:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lea_WMDE triaged this task as Medium priority.Mar 27 2018, 3:22 PM
Lea_WMDE updated the task description. (Show Details)
Lea_WMDE set the point value for this task to 3.

Change 444023 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Add ImporterComponentTest

https://gerrit.wikimedia.org/r/444023

Change 444033 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Add ImporterComponentTest case for 1 file revision

https://gerrit.wikimedia.org/r/444033

Change 444168 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Introduce WikiPageFactory to make Importer testable

https://gerrit.wikimedia.org/r/444168

Change 444189 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Test unedited/edited requests separately in ImporterComponentTest

https://gerrit.wikimedia.org/r/444189

Change 444168 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Introduce WikiPageFactory to make Importer testable

https://gerrit.wikimedia.org/r/444168

Change 444023 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Add ImporterComponentTest

https://gerrit.wikimedia.org/r/444023

Change 444033 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Add ImporterComponentTest case for 1 file revision

https://gerrit.wikimedia.org/r/444033

Change 444189 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Test unedited/edited requests separately in ImporterComponentTest

https://gerrit.wikimedia.org/r/444189