Page MenuHomePhabricator

Remove icon padding from VE format tools
Closed, ResolvedPublic1 Estimated Story Points

Description

Currently we have enough padding for an icon, this is because is Apex, the selected item is indicated with a checkmark.

Arguably this should be upstreamed to OOUI, as these tools are essentially icon-less by design.

Event Timeline

Esanders created this task.Mar 27 2018, 5:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2018, 5:29 PM

Change 422066 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Remove icon padding from format tools in WMUI

https://gerrit.wikimedia.org/r/422066

Deskana assigned this task to Esanders.Mar 27 2018, 6:34 PM
Deskana triaged this task as Medium priority.
Deskana edited projects, added VisualEditor (Current work); removed VisualEditor.
Deskana set the point value for this task to 1.
Deskana moved this task from Incoming to Code review on the VisualEditor (Current work) board.
Volker_E moved this task from Backlog to Resolved outside releases on the OOUI board.
Volker_E removed a subscriber: gerritbot.
Deskana closed this task as Resolved.Apr 9 2018, 3:28 PM
Deskana added a subscriber: Deskana.

The patch was merged, but gerritbot didn't want to tell us about it for some reason.

Change 431577 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Revert "Remove icon padding from format tools in WMUI"

https://gerrit.wikimedia.org/r/431577

Change 431577 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Revert "Remove icon padding from format tools in WMUI"

https://gerrit.wikimedia.org/r/431577

Change 432396 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (07e7f8369)

https://gerrit.wikimedia.org/r/432396

Change 432396 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (07e7f8369)

https://gerrit.wikimedia.org/r/432396