Page MenuHomePhabricator
Create Task
Maniphest T190862

Remove iframe upload code from mediawiki.api.upload module (resources/src/mediawiki/api/upload.js)
Closed, ResolvedPublic
Actions

Description

The mediawiki.api.upload iframe upload code in resources/src/mediawiki/api/upload.js is not used by any of the browsers currently supported by MediaWiki and it should be deleted.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove unused iframe upload codemediawiki/coremaster+5 -224
Remove iframe upload codemediawiki/coremaster+0 -108
Customize query in gerrit

Event Timeline

matmarex created this task.Mar 27 2018, 6:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2018, 6:11 PM
gerritbot subscribed.Mar 27 2018, 7:03 PM

Change 422219 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/core@master] Remove iframe upload code

https://gerrit.wikimedia.org/r/422219

gerritbot added a project: Patch-For-Review.Mar 27 2018, 7:03 PM
gerritbot added a comment.Mar 27 2018, 7:17 PM

Change 422219 abandoned by Jayprakash12345:
Remove iframe upload code

Reason:
Not easy task, hand over to Bartosz Dziewoński

https://gerrit.wikimedia.org/r/422219

matmarex removed a project: Patch-For-Review.Mar 27 2018, 7:50 PM

It's still relatively easy. Just not completely trivial. If it was trivial, I'd have fixed it instead of filing a task ;)

• Ramsey-WMF assigned this task to matthiasmullie.EditedMar 27 2018, 9:01 PM
• Ramsey-WMF triaged this task as Low priority.
• Ramsey-WMF moved this task from Untriaged to Triaged on the Multimedia board.
• Ramsey-WMF subscribed.

Assigning to Matthias to look at for now since he's making Upload changes anyway.

Kizule moved this task from Backlog to Doing on the good first task board.May 17 2018, 4:29 PM
• Phabricator_maintenance moved this task from Doing to Backlog on the good first task board.Sep 24 2018, 9:58 AM
matthiasmullie removed matthiasmullie as the assignee of this task.Oct 28 2020, 8:08 AM
matthiasmullie subscribed.
gerritbot added a comment.Feb 15 2021, 5:34 PM

Change 664315 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Remove unused iframe upload code

https://gerrit.wikimedia.org/r/664315

gerritbot added a project: Patch-For-Review.Feb 15 2021, 5:34 PM
gerritbot added a comment.Feb 17 2021, 1:11 AM

Change 664315 merged by jenkins-bot:
[mediawiki/core@master] Remove unused iframe upload code

https://gerrit.wikimedia.org/r/664315

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 17 2021, 2:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 17 2021, 2:10 AM
matmarex closed this task as Resolved.Feb 17 2021, 10:14 AM
matmarex claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits