Add & Edit Forms via wbeditentity
Open, Needs TriagePublic5 Story Points

Description

AC:

  • wbeditentity allows adding and editing of Lexeme forms per the same business logic implemented in wbladdform & wbleditformelements
    • forms can be editited as properties of Lexeme (using lexeme id [e.g. L1] as entity identifier to wbeditentity)
    • individual forms can be editited as form entities (using form id [e.g. L1-F2] as entity identifier to wbeditentity)
  • id is used instead of formId to identify forms inside wbeditentity (forms[]{ id: ... }), wbladdform, wbleditformelements

Info:

  • Rename of formId to id was done for wblremoveform in T189673 / https://gerrit.wikimedia.org/r/#/c/422099/
  • RemoveFormConstraint::many() describes (parts of) a Lexeme entity, not only the forms part as the name suggests. To allow for more actions (add, edit), this should be split - e.g. a collection in RemoveFormConstraint::many(), and a LexemeConstraint that describes the properties and different (action) constraints for them
Restricted Application added a project: Wikidata. · View Herald TranscriptWed, Mar 28, 8:40 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Pablo-WMDE updated the task description. (Show Details)Wed, Mar 28, 8:49 AM
RazShuty set the point value for this task to 5.
Pablo-WMDE updated the task description. (Show Details)Fri, Apr 6, 6:37 AM
Pablo-WMDE added subscribers: WMDE-leszek, Addshore.
Pablo-WMDE claimed this task.
Pablo-WMDE removed Pablo-WMDE as the assignee of this task.Tue, Apr 10, 7:26 AM

As it came out in the discussion documented in T190060 I note that it was decided that single representation should be represented using a structure: { "language": "en", "value": "colour" }. Note the "value" property being used instead of "representation".
That structure is intended to be used in all API dealing with doing changes to a form, i.e. not only wbeditentity, but also wbladdform, and wbleditformelements.

Pablo-WMDE updated the task description. (Show Details)Tue, Apr 17, 12:42 PM