Page MenuHomePhabricator

Undefined index: method in 1.31.0-wmf.26/extensions/FlaggedRevs/backend/FlaggedRevs.hooks.php on line 1186
Closed, DeclinedPublicPRODUCTION ERROR

Description

Error Message

Notice: Undefined index: method in /srv/mediawiki/php-1.31.0-wmf.26/extensions/FlaggedRevs/backend/FlaggedRevs.hooks.php on line 1186

Stack Trace

Notes

Event Timeline

Been around a few releases back, fwiw.

	public static function onEchoGetDefaultNotifiedUsers( $event, &$users ) {
		$extra = $event->getExtra();
		if ( $event->getType() == 'reverted' && $extra['method'] == 'flaggedrevs-reject' ) {
			foreach ( $extra['reverted-users-ids'] as $userId ) {
				$users[$userId] = User::newFromId( intval( $userId ) );
			}
		}
		return true;
	}

It seems Echo has provide a 'reverted' event without the 'method' key.
Looking at the current master all 'reverted' have the extra 'method', so this looks impossible

Krinkle added a subscriber: Krinkle.

Not seen in the last 30 days.

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM