Page MenuHomePhabricator

Create Grant Metrics staging tool
Closed, ResolvedPublic2 Estimated Story Points

Description

Grant Metrics is still in Beta (I think), but especially as popularity grows, we're going to need a safe place to test new features and bug fixes. We should create a dedicated staging tool, "grantmetrics-test" or the like.

Event Timeline

I think it's been approved? I can login and see https://tools.wmflabs.org/grantmetrics-test/app.php/programs now but I see only two of the columns (same problem as T187380).

Should be working! It uses a separate database, by the way.

MusikAnimal set the point value for this task to 2.EditedApr 2 2018, 11:40 PM

I see only two of the columns

It only shows available metrics, because they are "variable". If you create an event, all the columns should be there.

Also that app.php ... I think the OAuth redirect goes there (whoops). Not a big deal for the staging env. Things should still work at https://tools.wmflabs.org/grantmetrics-test/programs

I love this idea. Though I might need some clarification about what a staging tool does.

I love this idea. Though I might need some clarification about what a staging tool does.

It's just a testing environment for internal purposes. You of course are welcome to use it to test out new features we're working on, etc. :) but no real events should be ran on that tool. I've added a notice at the top of the page that explains this.

Is the database fully set up? I got the following error on https://tools.wmflabs.org/grantmetrics-test/app.php/programs/test/a/revisions :

The server said: An exception occurred while executing 'SELECT COUNT(id) FROM ( ) a': SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ') a' at line 2

Is the database fully set up? I got the following error on https://tools.wmflabs.org/grantmetrics-test/app.php/programs/test/a/revisions :

The server said: An exception occurred while executing 'SELECT COUNT(id) FROM ( ) a': SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ') a' at line 2

How did you manage to set the Wikis to "All"?!? https://tools.wmflabs.org/grantmetrics-test/programs/test/a That's why you're getting that error, I believe.

Also, app.php is in all URLs.

I accidentally set the OAuth callback to go to /grantmetrics-test/app.php. You can remove the app.php and it won't stay there as you click on links. I could create a new OAuth consumer with the correct callback, but I think better would be to redirect when attempting to browser to app.php.

It seems that if you enter only spaces in the wiki selection box, is says "Result not Found" (with a capital F by the way), but still lets you submit and then it has 'Wikis: All'. Replicated here: https://tools.wmflabs.org/grantmetrics-test/programs/test/Robert%27%29;_DROP_TABLE_programs;--

And I don't think it matters much about the URLs, if it's more bother to change it.

Aha, well that's a bug. I'll fix that now. Glad to hear the SQL injection didn't work, at least!

Niharika moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.
Niharika moved this task from In progress to Done on the Grant-Metrics board.