Maniphest T191003

SpamBlacklist : set extension name in composer.json
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Pyro853
	Mar 29 2018, 9:19 AM

Description

There is a composer.json file in extension, but the name and type of extension are not filled.

I add them to enable to install extension using composer

Details

	Subject	Repo	Branch	Lines +/-
	Revert "Revert "add extension name in composer.json""	mediawiki/extensions/SpamBlacklist	master	+2 -0
	add extension name in composer.json	mediawiki/extensions/SpamBlacklist	master	+2 -0

Customize query in gerrit

Related Objects

Mentioned Here: T188188: Composer support
T467: RfC: Extension management with Composer
T61872: Add mechanism to prevent autoloading of Composer installed extensions via LocalSettings.php

Event Timeline

Pyro853 created this task.Mar 29 2018, 9:19 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 29 2018, 9:19 AM

Change 422901 had a related patch set uploaded (by Pyro; owner: Pierre Boutet):
[mediawiki/extensions/SpamBlacklist@master] add extension name in composer.json

https://gerrit.wikimedia.org/r/422901

gerritbot added a project: Patch-For-Review.Mar 29 2018, 9:30 AM

Change 422901 merged by jenkins-bot:
[mediawiki/extensions/SpamBlacklist@master] add extension name in composer.json

https://gerrit.wikimedia.org/r/422901

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)).Mar 29 2018, 11:00 AM

Pyro853 closed this task as Resolved.Mar 29 2018, 11:28 AM

See T467 or T61872#1361864 and it links why extensions does not have the name in general. composer.json is mostly used to provide build tools or dependency, but not to be a dependency. That just as hint, I do not want to start a new discussion here.

I reverted the patch in Gerrit - it's intentional that this extension isn't installable via composer. As per T467, there's no plan to make more extensions installable via composer right now.

I am sorry about this decision, this patch doesn't enable autoloading with composer.
In T467, I see we decide to not " use composer to register components", but it is possible to install it with composer (i mean here just download the extension) whitout register the extension.

This is done for example in T188188

I made a few research, i didn't found any place where it is told about never user composer to install extension, whereas i found many explanation about how to use composer. Can you give me a link where there is a summary which support your point ?

As per T467, there's no plan to make more extensions installable via composer right now.

That's ridiculous. T467 does not forbid extensions to be installable via Composer. If you don't want to use Composer, just don't use it. What's the benefit of actively disallowing others to use it?

Change 423612 had a related patch set uploaded (by Pyro; owner: Pyro):
[mediawiki/extensions/SpamBlacklist@master] Revert "Revert "add extension name in composer.json""

https://gerrit.wikimedia.org/r/423612

MGChecker subscribed.Apr 25 2018, 7:44 PM

Hi !
Could we move forward on this ?
@Legoktm : could you answer about lasts comments above ?

The task has been re-opened, but it is blocked now !

@Legoktm: Could you please answer the last comment(s)? Thanks in advance!

My position hasn't changed since I last commented here, installing via composer isn't supported and adds an extra maintenance burden.

[…] maintenance burden.

What "burden"? As I said before:

That's ridiculous. T467 does not forbid extensions to be installable via Composer. If you don't want to use Composer, just don't use it. What's the benefit of actively disallowing others to use it?

Change 423612 abandoned by Jforrester:
[mediawiki/extensions/SpamBlacklist@master] Revert "Revert "add extension name in composer.json""

Reason:
No, thank you.