Page MenuHomePhabricator
Create Task
Maniphest T191026

Internal error: Invalid or virtual namespace -1 given.
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Steps to reproduce

  1. go to https://test.wikimedia.beta.wmflabs.org/wiki/Special:ImportFile
  2. enter https://commons.wikimedia.org/wiki/File:Constantin_Hansen,_Et_selskab_af_danske_kunstnere_i_Rom,_1837,_KMS3236,_SMK.jpg
  3. submit
  4. no changes to the file, just click import

Error message
Internal error
[Wrz0XApEE4AAAAYYHzQAAAAE] /wiki/Special:ImportFile MWException from line 121 of /srv/mediawiki/php-master/includes/page/WikiPage.php: Invalid or virtual namespace -1 given.

Backtrace:

#0 /srv/mediawiki/php-master/includes/context/RequestContext.php(231): WikiPage::factory(Title)
#1 /srv/mediawiki/php-master/includes/context/DerivativeContext.php(196): RequestContext->getWikiPage()
#2 /srv/mediawiki/php-master/extensions/SpamBlacklist/includes/SpamBlacklistHooks.php(31): DerivativeContext->getWikiPage()
#3 /srv/mediawiki/php-master/includes/Hooks.php(177): SpamBlacklistHooks::filterMergedContent(DerivativeContext, WikitextContent, Status, NULL, User, boolean)
#4 /srv/mediawiki/php-master/includes/Hooks.php(205): Hooks::callHook(string, array, array, NULL)
#5 /srv/mediawiki/php-master/extensions/FileImporter/src/Services/TextRevisionValidator.php(59): Hooks::run(string, array)
#6 /srv/mediawiki/php-master/extensions/FileImporter/src/Services/Importer.php(265): FileImporter\Services\TextRevisionValidator->validate(Title, User, WikitextContent, NULL, boolean)
#7 /srv/mediawiki/php-master/extensions/FileImporter/src/Services/Importer.php(140): FileImporter\Services\Importer->validateFileInfoText(User, FileImporter\Data\ImportPlan)
#8 /srv/mediawiki/php-master/extensions/FileImporter/src/Services/Importer.php(103): FileImporter\Services\Importer->importInternal(User, FileImporter\Data\ImportPlan)
#9 /srv/mediawiki/php-master/extensions/FileImporter/src/SpecialImportFile.php(283): FileImporter\Services\Importer->import(User, FileImporter\Data\ImportPlan)
#10 /srv/mediawiki/php-master/extensions/FileImporter/src/SpecialImportFile.php(177): FileImporter\SpecialImportFile->doImport(FileImporter\Data\ImportPlan)
#11 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(522): FileImporter\SpecialImportFile->execute(NULL)
#12 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(568): SpecialPage->run(NULL)
#13 /srv/mediawiki/php-master/includes/MediaWiki.php(288): SpecialPageFactory::executePath(Title, RequestContext)
#14 /srv/mediawiki/php-master/includes/MediaWiki.php(861): MediaWiki->performRequest()
#15 /srv/mediawiki/php-master/includes/MediaWiki.php(524): MediaWiki->main()
#16 /srv/mediawiki/php-master/index.php(42): MediaWiki->run()
#17 /srv/mediawiki/w/index.php(3): include(string)
#18 {main}

Details

SubjectRepoBranchLines +/-
Document validators to throw ValidationExceptionmediawiki/extensions/FileImportermaster+8 -2
Add missing WikiPage object to edit hook contextmediawiki/extensions/FileImportermaster+16 -9
Customize query in gerrit

Related Objects

Event Timeline

JStrodt_WMDE created this task.Mar 29 2018, 2:16 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptMar 29 2018, 2:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lea_WMDE subscribed.Apr 3 2018, 7:39 AM

same error mentioned here T190272: Test RTL- compatibility of FileImporter + FileExporter

Lea_WMDE moved this task from Backlog to Tickets in preparation/investigation on the Move-Files-To-Commons board.Apr 3 2018, 8:18 AM
WMDE-Fisch added a project: WMDE-QWERTY-Sprint-2018-04-03.Apr 3 2018, 3:24 PM
WMDE-Fisch set the point value for this task to 5.
gerritbot subscribed.Apr 3 2018, 5:25 PM

Change 423743 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/FileImporter@master] Add missing WikiPage object to edit hook context

https://gerrit.wikimedia.org/r/423743

gerritbot added a project: Patch-For-Review.Apr 3 2018, 5:25 PM
WMDE-Fisch claimed this task.Apr 3 2018, 5:26 PM
WMDE-Fisch moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2018-04-03 board.
WMDE-Fisch mentioned this in rEFLI09b94b75a383: Add missing WikiPage object to edit hook context.Apr 3 2018, 5:28 PM
WMDE-Fisch added a comment.Apr 3 2018, 5:30 PM

The error showed only in combination with the SpamBlacklist extension. It uses the WikiPage object from the Context given to the Hook triggering the extension. I build that context in the FileImporter and used a variant where it seems that object could not be build properly. This is fixed in the patch.

WMDE-Fisch added a comment.Apr 3 2018, 5:32 PM

And for the record: The Hook that we trigger for the AbuseFilter also triggers the SpamBlacklist extension. So we can check this as being consider in our import process.

JStrodt_WMDE awarded a token.Apr 4 2018, 7:33 AM
Lea_WMDE mentioned this in T190170: Check if FileImporter respects TitleBlacklist extension.Apr 4 2018, 10:03 AM
Lea_WMDE moved this task from Tickets in preparation/investigation to Tickets in sprint on the Move-Files-To-Commons board.
WMDE-Fisch mentioned this in rEFLId12231531c73: Add missing WikiPage object to edit hook context.Apr 4 2018, 11:43 AM
gerritbot added a comment.Apr 5 2018, 2:50 PM

Change 424324 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Document validators to throw ValidationException

https://gerrit.wikimedia.org/r/424324

thiemowmde mentioned this in rEFLIe20ab3b34629: Document validators to throw ValidationException.Apr 5 2018, 2:51 PM
gerritbot added a comment.Apr 5 2018, 2:53 PM

Change 423743 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Add missing WikiPage object to edit hook context

https://gerrit.wikimedia.org/r/423743

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)).Apr 5 2018, 3:00 PM
WMDE-Fisch moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2018-04-03 board.Apr 5 2018, 3:10 PM

One note when testing: The above image does not work now since I imported it already while testing, so you have to get another one. :-)

See https://test.wikimedia.beta.wmflabs.org/w/index.php?title=File:Constantin_Hansen,_Et_selskab_af_danske_kunstnere_i_Rom,_1837,_KMS3236,_SMK.jpg&action=history

gerritbot added a comment.Apr 5 2018, 4:21 PM

Change 424324 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Document validators to throw ValidationException

https://gerrit.wikimedia.org/r/424324

Lea_WMDE added a comment.Apr 6 2018, 11:06 AM

So I tested it on the test server with https://commons.wikimedia.org/wiki/File:Sinfon%C3%ADa_de_las_Piedras,_valle_de_Garni,_Armenia,_2016-10-02,_DD_33.jpg and the result is still a bug:

Bildschirmfoto 2018-04-06 um 13.05.26.png (776×2 px, 284 KB)

WMDE-Fisch added a comment.Apr 9 2018, 9:25 AM

Apart from that being a different error ... it worked for me :-/

Import succeeded
"https://commons.wikimedia.org/wiki/File:Sinfonía_de_las_Piedras,_valle_de_Garni,_Armenia,_2016-10-02,_DD_33.jpg" has been imported to "File:Sinfonía de las Piedras, valle de Garni, Armenia, 2016-10-02, DD 33.jpg"

Also the ticket's error was part of the validation step. This error came from the commit operation that follows. I will create a task to investigate.

WMDE-Fisch mentioned this in T191773: Investigate failed import attempt with "Sinfonía de las Piedras...".Apr 9 2018, 9:37 AM
Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2018-04-03 board.Apr 12 2018, 9:45 AM
JStrodt_WMDE closed this task as Resolved.Apr 12 2018, 11:49 AM

Tested it with three different files from Commons, edited title and file info – and it worked! Thanks for fixing this bug.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL