Maniphest T191068

1.32.0-wmf.22 deployment blockers
Closed, ResolvedPublicRelease
Actions

Assigned To

Authored By

	greg
	Mar 29 2018, 6:08 PM

Details

Release Version: 1.32.0-wmf.22
Release Date: Sep 17 2018, 12:00 AM

2018 week 38 1.32-wmf.22 Changes wmf/1.32.0-wmf.22

This MediaWiki Train Deployment is scheduled for the week of Monday, September 17th:

Monday September 17th	Tuesday, September 18th	Wednesday, September 19th	Thursday, September 20th	Friday
Backports only.	Branch `wmf.22` and deploy to Group 0 Wikis.	Deploy `wmf.22` to Group 1 Wikis.	Deploy `wmf.22` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.22 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.32.0-wmf.21

Next: 1.32.0-wmf.23

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	hashar	T191068 1.32.0-wmf.22 deployment blockers
Resolved	PRODUCTION ERROR	Tgr	T204757 [OAuth] PHP Fatal Error: Call to undefined method MediaWiki\Extensions\OAuth\MWOAuthDAOAccessControl::getForHtml()
Resolved	PRODUCTION ERROR	Catrope	T204758 EchoForeignWikiRequest emits PHP error "Undefined index: csrftoken"
Resolved	PRODUCTION ERROR	Nikerabbit	T204797 [Regression 1.32.0-wmf.22] ParserOutput::getLanguageLinks returns invalid values (Undefined index from ApiParse and LinksUpdate)
Resolved	PRODUCTION ERROR	Catrope	T204826 EchoForeignWikiRequest emits PHP error "Undefined index: query"
Resolved		Esanders	T204873 "Special page" tab accidentally renamed to "CollabPad"
Resolved	PRODUCTION ERROR	MaxSem	T204864 [1.32.0-wmf.22] includes/GlobalPreferencesFactory.php: PHP Notice: Undefined index: section
Resolved		Ladsgroup	T204961 ORES requests for wikidatawiki models=damaging end up with HTTP request timed out

Event Timeline

greg created this task.Mar 29 2018, 6:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 29 2018, 6:08 PM

greg triaged this task as Medium priority.Mar 29 2018, 6:15 PM

Liuxinyu970226 subscribed.Jul 24 2018, 10:48 PM

greg assigned this task to hashar.Aug 30 2018, 4:18 PM

Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptAug 30 2018, 4:18 PM

Ciencia_Al_Poder added a subtask: T204669: Slow access to Special:Contributions on mediawiki.org (due to enabling actor table WRITE_BOTH mode).Sep 18 2018, 9:40 AM

Checked T204669: Slow access to Special:Contributions on mediawiki.org (due to enabling actor table WRITE_BOTH mode) with DBA / Brad Jorsch, that is an ongoing experimentation on group0 done via a config change: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/460923

Or in short that is not a train blocker.

Mentioned in SAL (#wikimedia-operations) [2018-09-18T13:21:22Z] <hashar> Cutting branches wmf/1.32.0-wmf.22 | T191068

Release notes pasted at https://www.mediawiki.org/wiki/MediaWiki_1.32/wmf.22/Changelog

I will deploy to group0 later today, after 19:00UTC.

Krinkle added a subtask: T204757: [OAuth] PHP Fatal Error: Call to undefined method MediaWiki\Extensions\OAuth\MWOAuthDAOAccessControl::getForHtml().Sep 18 2018, 7:47 PM

Krinkle added a subtask: T204758: EchoForeignWikiRequest emits PHP error "Undefined index: csrftoken".Sep 18 2018, 7:50 PM

hashar closed subtask T204757: [OAuth] PHP Fatal Error: Call to undefined method MediaWiki\Extensions\OAuth\MWOAuthDAOAccessControl::getForHtml() as Resolved.Sep 18 2018, 8:05 PM

Catrope added a subtask: T204764: DB error in PageTriage: Unknown column 'actor_rev_user.actor_user' in 'on clause'.Sep 18 2018, 8:17 PM

Pushed to group0 around 19:00 UTC

There are a few issues related to the newish actor table:

The current blockers related to actor:

The feature is thanksfully feature flagged and only enabled on a few wikis https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/460923/1/wmf-config/InitialiseSettings.php That includes mediawiki.org though.

I don't think they are blockers for wmf.22, probably we can move them as sub task of some other task.

hashar added a subtask: T204767: Special:ActiveUsers fails with "Error: 1054 Unknown column 'rc_actor' in 'on clause' (10.192.32.110)".Sep 18 2018, 8:41 PM

Krinkle added a subtask: T204797: [Regression 1.32.0-wmf.22] ParserOutput::getLanguageLinks returns invalid values (Undefined index from ApiParse and LinksUpdate).Sep 19 2018, 2:52 AM

I have removed subtasks related to ActorTableSchemaMigrationStage which was enabled on Monday 09/17. That is part of a feature flagged migration (T188327) and is not train related.

Krinkle added a subtask: T204826: EchoForeignWikiRequest emits PHP error "Undefined index: query".Sep 19 2018, 2:27 PM

Krinkle removed a subtask: T204756: DerivedPageDataUpdater emits "PHP Notice: Undefined index: 1" from LinksUpdate.php.

zeljkofilipin added a project: User-zeljkofilipin.Sep 19 2018, 2:52 PM

zeljkofilipin moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.

zeljkofilipin moved this task from Backlog 🪒 to Watching 📺 on the User-zeljkofilipin board.

hashar closed subtask T204758: EchoForeignWikiRequest emits PHP error "Undefined index: csrftoken" as Resolved.Sep 19 2018, 6:36 PM

Mentioned in SAL (#wikimedia-operations) [2018-09-19T19:30:06Z] <hashar> while promoting group1 to 1.32.0-wmf.22 lot of web requests timed out at 60 seconds. Roughly from 19:24 to 19:28. But that is no more occurring | T191068

I noticed a large spike of web requests timeouts when promoting group1. That solved by itself eventually. Filled as T204871

Legoktm added a subtask: T204873: "Special page" tab accidentally renamed to "CollabPad" .Sep 19 2018, 8:03 PM

Catrope closed subtask T204826: EchoForeignWikiRequest emits PHP error "Undefined index: query" as Resolved.Sep 19 2018, 8:28 PM

Jdforrester-WMF closed subtask T204873: "Special page" tab accidentally renamed to "CollabPad" as Resolved.Sep 19 2018, 9:25 PM

Jdforrester-WMF subscribed.

Krinkle added a subtask: T204864: [1.32.0-wmf.22] includes/GlobalPreferencesFactory.php: PHP Notice: Undefined index: section.Sep 19 2018, 10:58 PM

Krinkle closed subtask T204864: [1.32.0-wmf.22] includes/GlobalPreferencesFactory.php: PHP Notice: Undefined index: section as Resolved.Sep 20 2018, 1:44 AM

Krinkle closed subtask T204797: [Regression 1.32.0-wmf.22] ParserOutput::getLanguageLinks returns invalid values (Undefined index from ApiParse and LinksUpdate) as Resolved.

hashar added a subtask: T204961: ORES requests for wikidatawiki models=damaging end up with HTTP request timed out.Sep 20 2018, 2:54 PM

1.32.0-wmf.22 has been rolled to all wikis and seems all fine.

Thank you @Tgr and @Anomie to have shown up for errors due to the new actor table. I even a patch for a task before I had fully described it. The issues we found are now attached to T188327

@Catrope / @SBisson Echo looks good, the undefined index got quickly fixed (T204758, T204826). Much appreciated.

@Esanders / @Multichill / @Legoktm who have fixed a special page name. An issue solved so fast I have only noticed it now (T204873)

@Krinkle who have made PHP Notices to be reported with the ERROR level, they show up in logstash with a stacktrace, wiki info etc. That is way better than the single line that comes from HHVM stdout/stderr. Thank you for all the log tasks you have filled.

And several from above + @Nikerabbit who got rid of spam log from the Parser (T204797).

Actions for later:

Thank you everyone.

antoine-approve