Page MenuHomePhabricator
Create Task
Maniphest T191106

[BUG] The tutorial in the Android Wikipedia app has sliding in the wrong direction in RTL devices
Closed, ResolvedPublic
Actions

Assigned To
Dbrant
Authored By
Amire80
Mar 30 2018, 8:35 AM
Tags
Referenced Files
F18253015: Screenshot_20180514-154813.png
May 14 2018, 2:02 PM
F18253013: Screenshot_20180514-154808.png
May 14 2018, 2:02 PM
F16460632: Screenshot_20180330-112656.png
Mar 30 2018, 8:37 AM
F16460635: Screenshot_20180330-112647.png
Mar 30 2018, 8:37 AM
Subscribers
ABorbaWMF
Aklapper
Amire80
gerritbot
RHo

Description

Steps to reproduce

  1. Set the device language to an RTL language, for example Hebrew.
  2. Clear the app data, in order to see the tutorial.
  3. Open the app.
Expected

App onboarding screens respects RTL language

Actual

The dots at the bottom and the arrow are in a direction that is opposite from the expected sliding direction.

Screenshot_20180330-112656.png (1×720 px, 388 KB)

Screenshot_20180330-112647.png (1×720 px, 407 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make ViewPagers aware of RTL.apps/android/wikipediamaster+23 -6
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Mar 30 2018, 8:35 AM
Restricted Application added projects: I18n, Wikipedia-Android-App-Backlog. · View Herald TranscriptMar 30 2018, 8:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Amire80 updated the task description. (Show Details)Mar 30 2018, 8:37 AM
Amire80 mentioned this in T109611: the bubble that teaches the user about the TOC button on the Wikipedia Android app may appear on the wrong side with LTR/RTL are mixed up.Mar 30 2018, 8:39 AM
RHo added a project: Android-app-feature-Multilingual.Mar 30 2018, 3:05 PM
Amire80 moved this task from Untriaged to RTL on the I18n board.Apr 2 2018, 11:56 AM
RHo mentioned this in T190922: Add language detection and selection to app onboarding.Apr 16 2018, 9:43 PM
LGoto edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly); removed Wikipedia-Android-App-Backlog.Apr 17 2018, 4:45 PM
• Charlotte renamed this task from The tutorial in the Android Wikipedia app has sliding in the wrong direction in RTL devices to [BUG] The tutorial in the Android Wikipedia app has sliding in the wrong direction in RTL devices.May 1 2018, 4:59 PM
• Charlotte triaged this task as Low priority.
gerritbot subscribed.May 8 2018, 4:17 PM

Change 431778 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Make ViewPagers aware of RTL.

https://gerrit.wikimedia.org/r/431778

gerritbot added a project: Patch-For-Review.May 8 2018, 4:17 PM
Dbrant claimed this task.May 8 2018, 4:17 PM
Dbrant moved this task from Backlog to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
gerritbot added a comment.May 8 2018, 11:10 PM

Change 431778 merged by jenkins-bot:
[apps/android/wikipedia@master] Make ViewPagers aware of RTL.

https://gerrit.wikimedia.org/r/431778

Dbrant moved this task from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.May 10 2018, 6:27 PM
RHo updated the task description. (Show Details)May 14 2018, 1:49 PM
RHo moved this task from Design signoff to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.May 14 2018, 2:02 PM
RHo subscribed.

LGTM on Pixel 2 (8.1), Wikipedia v2.7.232-alpha-2018-05-10. Moved to QA for further testing

Screenshot_20180514-154808.png (1×1 px, 1 MB)

Screenshot_20180514-154813.png (1×1 px, 1 MB)

ABorbaWMF moved this task from QA signoff to Ready for signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.May 16 2018, 4:48 PM
ABorbaWMF subscribed.

Looks good to me on 2.7.232-alpha-2018-05-16

Dbrant closed this task as Resolved.Jun 27 2018, 8:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits