Page MenuHomePhabricator

IABot does not correctly handle link labels containing an internal link or a template
Closed, ResolvedPublic

Description

Hello, there is a syntax error introduced by the bot in this diff : https://fr.wikipedia.org/w/index.php?title=Mat%C3%B3&diff=146934404&oldid=134181526

The bot removes the two right brackets of the internal link present in the external link description. I think that this is not the first time I see this bug but I can't find another example for now.

Event Timeline

Using links within link labels is definitely not valid wikitext and should be cleaned up, even though it seems to be rendered OK. If links within links are a frequent occurence, perhaps IABot should detect and ignore these links, but I guess that it should not be required to deal with clearly invalid markup.

Regarding the use of templates in link titles, you are correct, IABot should keep the template.

Note that this is somewhat related to T180198 and a fix for one of the bugs can probably be used to fix the other.

Cirdan renamed this task from Syntax error on fr.wiki when there is an internal link in exteral link label to IABot does not correctly handle link labels containing an internal link or a template.Apr 20 2018, 5:12 PM
Cirdan triaged this task as Medium priority.Apr 29 2018, 7:46 AM

Hello,
In this case https://fr.wikipedia.org/w/index.php?title=Torfou_(Maine-et-Loire)&diff=148131708&oldid=148055941 IABot replace a link in a template parameter and broke the parent template ("}}" missing).

@Shawn This seems to be a different problem. In your diff, the bot does not correctly recognize the start and end of the template. Can you please open a separate bug report? Thanks!

Using links within link labels is definitely not valid wikitext and should be cleaned up, even though it seems to be rendered OK. If links within links are a frequent occurence, perhaps IABot should detect and ignore these links, but I guess that it should not be required to deal with clearly invalid markup.

Regarding the use of templates in link titles, you are correct, IABot should keep the template.

Note that this is somewhat related to T180198 and a fix for one of the bugs can probably be used to fix the other.

That's a misformatted external link. This is a classic GIGO example.

This doesn't appear to be happening anymore.