Page MenuHomePhabricator

DeletePagesForGood shouldn't destroy all log entries for user pages
Open, Needs TriagePublic

Description

Create an account called "Example" on a wiki with the DeletePagesForGood extension installed, or just log in to an existing account. Then, if the user page doesn't already exist, create it. Next, log out and log in to an admin account. Finally, use the extension to permanently delete the user page. All the log entries for the user page are completely destroyed, including the user creation log entry. This shouldn't happen though. Likewise, if the user had been blocked or had user rights changed, all the corresponding log entries would also be destroyed, but they shouldn't be. In general, the extension should only destroy log entries that are not of types covered in the getLogTypesOnUser() function in SpecialLog.php (which include extra log types that extensions define in the GetLogTypesOnUser hook, like renameuser and thanks in the respective extensions). And if a recent log entry shouldn't be destroyed, neither should the corresponding recent changes entry.

Event Timeline

Im not sure if this request conflicts with the GDPR?

Change 512733 had a related patch set uploaded (by GeoffreyT2000; owner: GeoffreyT2000):
[mediawiki/extensions/DeletePagesForGood@master] Keep some logs when permanently deleting a page

https://gerrit.wikimedia.org/r/512733

Im not sure if this request conflicts with the GDPR?

IANAL, but I guess it could.

One the other side, not all websites are subject to GDPR (so this feature could be interesting where GDPR does not apply, e.g. an intranet MediaWiki in Japan), and this extension could be used for other purposes than GDPR requests "right to erasure" (e.g. save some disk space or remove vandals, and we could want to keep minimal logs in these cases).

I find the proposed patch (even if globally good as proposed, except the minor defaults) would be even better if the administrator user have a checkbox to remove or not the minimal user logs; like that s/he could choose depending on the soon-deleted-user.

Change 512733 abandoned by GeoffreyT2000:

[mediawiki/extensions/DeletePagesForGood@master] Keep some logs when permanently deleting a page

Reason:

For now

https://gerrit.wikimedia.org/r/512733