The @ sign doesn't work with scream while \MediaWiki\suppressWarnings() also quiets the scream.
Description
Details
Related Objects
Event Timeline
Change 423576 had a related patch set uploaded (by MarkAHershberger; owner: MarkAHershberger):
[mediawiki/core@master] Use MediaWiki\SuppressWarnings around trigger_error('') instead @
Change 423579 had a related patch set uploaded (by MarkAHershberger; owner: MarkAHershberger):
[mediawiki/extensions/Scribunto@master] Use MediaWiki\SuppressWarnings around trigger_error('') instead @
Why should we care about some random pecl extension that's designed to break things?
I say let's wait until T176370 is done so we can change it to error_clear_last() instead of making the code even more complicated
I agree. If this is just about scream, it isn't worth it.
However, use of @ to hide errors is deprecated and \MediaWiki\suppressWarnings is preferred. The preferred method also happens to mollify scream.
Change 423579 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Use MediaWiki\SuppressWarnings around trigger_error('') instead @
Change 425336 had a related patch set uploaded (by MarkAHershberger; owner: MarkAHershberger):
[mediawiki/core@REL1_27] Use MediaWiki\SuppressWarnings around trigger_error('') instead @
Change 425424 had a related patch set uploaded (by MarkAHershberger; owner: MarkAHershberger):
[mediawiki/extensions/Scribunto@REL1_27] Use MediaWiki\SuppressWarnings around trigger_error('') instead @
Change 425424 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@REL1_27] Use MediaWiki\SuppressWarnings around trigger_error('') instead @
Change 427180 had a related patch set uploaded (by MarkAHershberger; owner: MarkAHershberger):
[mediawiki/core@REL1_29] Use MediaWiki\SuppressWarnings around trigger_error('') instead @
Change 427184 had a related patch set uploaded (by MarkAHershberger; owner: MarkAHershberger):
[mediawiki/core@REL1_30] Use MediaWiki\SuppressWarnings around trigger_error('') instead @
Change 427184 merged by jenkins-bot:
[mediawiki/core@REL1_30] Use MediaWiki\SuppressWarnings around trigger_error('') instead @
Change 427180 merged by jenkins-bot:
[mediawiki/core@REL1_29] Use MediaWiki\SuppressWarnings around trigger_error('') instead @
Change 425336 merged by jenkins-bot:
[mediawiki/core@REL1_27] Use MediaWiki\SuppressWarnings around trigger_error('') instead @
Change 423576 merged by D3r1ck01:
[mediawiki/core@master] Use MediaWiki\SuppressWarnings around trigger_error('') instead @
Change 546393 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/Scribunto@master] Replace trigger_error('') magic with error_clear_last()
Change 546393 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Replace trigger_error('') magic with error_clear_last()