Page MenuHomePhabricator
Create Task
Maniphest T191247

Use MediaWiki\SuppressWarnings around trigger_error('') instead @trigger_error('')
Closed, ResolvedPublic
Actions

Description

The @ sign doesn't work with scream while \MediaWiki\suppressWarnings() also quiets the scream.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Scribuntomaster+1 -3Replace trigger_error('') magic with error_clear_last()
mediawiki/coremaster+3 -2Use MediaWiki\SuppressWarnings around trigger_error('') instead @
mediawiki/coreREL1_27+5 -3Use MediaWiki\SuppressWarnings around trigger_error('') instead @
mediawiki/coreREL1_29+5 -3Use MediaWiki\SuppressWarnings around trigger_error('') instead @
mediawiki/coreREL1_30+5 -4Use MediaWiki\SuppressWarnings around trigger_error('') instead @
mediawiki/extensions/ScribuntoREL1_27+3 -1Use MediaWiki\SuppressWarnings around trigger_error('') instead @
mediawiki/extensions/Scribuntomaster+3 -2Use MediaWiki\SuppressWarnings around trigger_error('') instead @
Customize query in gerrit

Related Objects

Event Timeline

MarkAHershberger created this task.Apr 2 2018, 10:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2018, 10:12 PM
gerritbot added a subscriber: gerritbot.Apr 2 2018, 10:27 PM

Change 423576 had a related patch set uploaded (by MarkAHershberger; owner: MarkAHershberger):
[mediawiki/core@master] Use MediaWiki\SuppressWarnings around trigger_error('') instead @

https://gerrit.wikimedia.org/r/423576

gerritbot added a project: Patch-For-Review.Apr 2 2018, 10:27 PM
gerritbot added a comment.Apr 2 2018, 10:40 PM

Change 423579 had a related patch set uploaded (by MarkAHershberger; owner: MarkAHershberger):
[mediawiki/extensions/Scribunto@master] Use MediaWiki\SuppressWarnings around trigger_error('') instead @

https://gerrit.wikimedia.org/r/423579

Anomie added a subscriber: Anomie.Apr 3 2018, 12:25 AM

Why should we care about some random pecl extension that's designed to break things?

I say let's wait until T176370 is done so we can change it to error_clear_last() instead of making the code even more complicated

MarkAHershberger added a comment.Apr 3 2018, 3:41 PM
In T191247#4099204, @Anomie wrote:

Why should we care about some random pecl extension that's designed to break things?

I agree. If this is just about scream, it isn't worth it.

However, use of @ to hide errors is deprecated and \MediaWiki\suppressWarnings is preferred. The preferred method also happens to mollify scream.

gerritbot added a comment.Apr 4 2018, 2:16 PM

Change 423579 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Use MediaWiki\SuppressWarnings around trigger_error('') instead @

https://gerrit.wikimedia.org/r/423579

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)).Apr 4 2018, 3:00 PM
gerritbot added a comment.Apr 10 2018, 7:09 PM

Change 425336 had a related patch set uploaded (by MarkAHershberger; owner: MarkAHershberger):
[mediawiki/core@REL1_27] Use MediaWiki\SuppressWarnings around trigger_error('') instead @

https://gerrit.wikimedia.org/r/425336

gerritbot added a comment.Apr 10 2018, 9:39 PM

Change 425424 had a related patch set uploaded (by MarkAHershberger; owner: MarkAHershberger):
[mediawiki/extensions/Scribunto@REL1_27] Use MediaWiki\SuppressWarnings around trigger_error('') instead @

https://gerrit.wikimedia.org/r/425424

gerritbot added a comment.Apr 10 2018, 9:42 PM

Change 425424 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@REL1_27] Use MediaWiki\SuppressWarnings around trigger_error('') instead @

https://gerrit.wikimedia.org/r/425424

gerritbot added a comment.Apr 17 2018, 5:49 PM

Change 427180 had a related patch set uploaded (by MarkAHershberger; owner: MarkAHershberger):
[mediawiki/core@REL1_29] Use MediaWiki\SuppressWarnings around trigger_error('') instead @

https://gerrit.wikimedia.org/r/427180

gerritbot added a comment.Apr 17 2018, 5:59 PM

Change 427184 had a related patch set uploaded (by MarkAHershberger; owner: MarkAHershberger):
[mediawiki/core@REL1_30] Use MediaWiki\SuppressWarnings around trigger_error('') instead @

https://gerrit.wikimedia.org/r/427184

gerritbot added a comment.Apr 17 2018, 6:51 PM

Change 427184 merged by jenkins-bot:
[mediawiki/core@REL1_30] Use MediaWiki\SuppressWarnings around trigger_error('') instead @

https://gerrit.wikimedia.org/r/427184

ReleaseTaggerBot added a project: MW-1.30-release-notes.Apr 17 2018, 7:00 PM
gerritbot added a comment.Apr 17 2018, 7:02 PM

Change 427180 merged by jenkins-bot:
[mediawiki/core@REL1_29] Use MediaWiki\SuppressWarnings around trigger_error('') instead @

https://gerrit.wikimedia.org/r/427180

gerritbot added a comment.Apr 17 2018, 7:02 PM

Change 425336 merged by jenkins-bot:
[mediawiki/core@REL1_27] Use MediaWiki\SuppressWarnings around trigger_error('') instead @

https://gerrit.wikimedia.org/r/425336

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.29-release-notes.Apr 17 2018, 8:00 PM
gerritbot added a comment.Dec 19 2018, 5:15 PM

Change 423576 merged by D3r1ck01:
[mediawiki/core@master] Use MediaWiki\SuppressWarnings around trigger_error('') instead @

https://gerrit.wikimedia.org/r/423576

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.12; 2019-01-08).Dec 19 2018, 6:01 PM
Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 2:53 PM
gerritbot added a comment.Oct 28 2019, 7:08 AM

Change 546393 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/Scribunto@master] Replace trigger_error('') magic with error_clear_last()

https://gerrit.wikimedia.org/r/546393

gerritbot added a project: Patch-For-Review.Oct 28 2019, 7:08 AM
gerritbot added a comment.Oct 28 2019, 2:08 PM

Change 546393 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Replace trigger_error('') magic with error_clear_last()

https://gerrit.wikimedia.org/r/546393

Maintenance_bot removed a project: Patch-For-Review.Oct 28 2019, 2:10 PM
jenkins-bot mentioned this in rELUA764847164aec: Replace trigger_error('') magic with error_clear_last().Oct 28 2019, 2:16 PM
Anomie closed this task as Resolved.Oct 28 2019, 2:30 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Oct 28 2019, 3:00 PM
MaxSem mentioned this in T103671: Empty PHP Notice in wfShellExec (GlobalFunctions.php).Oct 29 2019, 7:13 AM
Aklapper removed a subscriber: Anomie.Fri, Oct 16, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL