Page MenuHomePhabricator
Create Task
Maniphest T191262

Inconsistencies in the bulk edit view
Closed, ResolvedPublic
Actions

Description

Why are we doing this?

There are currently some inconsistencies between the bulk edit view and other parts of the app / reading list feature

Proposed solution

F 02a.png (1×750 px, 358 KB)
Zeplin: https://zpl.io/VQ0pYAn
  • There should be an HR above the bulk edit action bar
  • Cancel, Sort and the bulk edit actions should all be the same font size (16pts)

Related Objects

Event Timeline

cmadeo created this task.Apr 2 2018, 11:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2018, 11:37 PM
cmadeo triaged this task as Medium priority.Apr 2 2018, 11:37 PM
cmadeo moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.
cmadeo updated the task description. (Show Details)
• NHarateh_WMF claimed this task.Apr 3 2018, 2:20 AM
• NHarateh_WMF moved this task from Needs Engineering Sync to Doing on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.
• NHarateh_WMF moved this task from Doing to Needs Code Review on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 3 2018, 12:52 PM
• NHarateh_WMF mentioned this in rAPIOS65cf7db9b47b: Merge branch 'develop' into bug/T191262.Apr 3 2018, 12:53 PM
• NHarateh_WMF mentioned this in rAPIOS825308a8bb29: Merge branch 'develop' into bug/T191262.Apr 3 2018, 8:30 PM
cmadeo mentioned this in T186082: As a user of reading lists, I would like to be able to sort and search for articles within a reading list.Apr 3 2018, 11:07 PM
Diffusion mentioned this in rAPIOScfe8a85f8993: Merge branch 'develop' into bug/T191262.Apr 3 2018, 11:31 PM
Diffusion mentioned this in rAPIOS4c9848965533: Merge pull request #2159 from wikimedia/bug/T191262.Apr 3 2018, 11:59 PM
• NHarateh_WMF moved this task from Needs Code Review to Waiting for Build on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 4 2018, 2:56 PM
• NHarateh_WMF moved this task from Waiting for Build to Needs Design Review on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 4 2018, 5:02 PM
cmadeo moved this task from Needs Design Review to Ready for Development on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 4 2018, 5:30 PM

@NHarateh_WMF the updates to the bulk editing look really good!
It still feels like Cancel is larger than Sort and the bulk editing actions though? Could they all be made to be 16pts?
Also could we bold the Cancel when the bulk editing view is open?

Thanks!

• NHarateh_WMF moved this task from Ready for Development to Needs Code Review on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 4 2018, 11:46 PM
• NHarateh_WMF moved this task from Needs Code Review to Waiting for Build on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 5 2018, 5:18 PM
• NHarateh_WMF mentioned this in rAPIOS67512c3e98b1: Merge branch 'develop' into followup/T191262.Apr 5 2018, 5:25 PM
• NHarateh_WMF mentioned this in rAPIOS91b65b529633: Merge branch 'develop' into followup/T191262.Apr 5 2018, 9:34 PM
• NHarateh_WMF mentioned this in rAPIOS2b25b4be465d: Merge branch 'followup/T191262' of https://github.com/wikimedia/wikipedia-ios….
• NHarateh_WMF mentioned this in rAPIOSdaf63a4b03db: Merge branch 'develop' into followup/T191262.Apr 5 2018, 10:15 PM
Diffusion mentioned this in rAPIOSdc3b998bc84a: Merge branch 'develop' into followup/T191262.Apr 5 2018, 11:30 PM
Diffusion mentioned this in rAPIOS5067f1e16fa2: Merge pull request #2173 from wikimedia/followup/T191262.Apr 5 2018, 11:37 PM
• NHarateh_WMF moved this task from Waiting for Build to Needs Design Review on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 6 2018, 7:38 PM
cmadeo moved this task from Needs Design Review to Needs QA on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 9 2018, 9:50 PM

@NHarateh_WMF Looks good!
One small tweak, could 'Delete' be red instead of blue on the bulk edit actions for reading lists?
Thanks, sorry I neglected to notice this before creating the ticket.

Nicholas.tsg subscribed.Apr 11 2018, 7:50 PM

Device: iOS 11 (iPhone 7)
App Version 5.8.0 (1377)

Here's a screencap of how it looks right now.

T191262.jpg (1×750 px, 123 KB)

• JMinor moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 12 2018, 6:49 PM
LGoto moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Apr 17 2018, 5:44 PM
• JMinor closed this task as Resolved.Apr 17 2018, 11:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL