Page MenuHomePhabricator
Create Task
Maniphest T191297

Disable the "try syntax highlighting" popup for all users
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

We need to test this behavior before deciding what to do with this ticket. Currently using Code Mirror requires being logged-in, but if we graduate it from beta it may be available to logged-out users.

Screen Shot 2018-04-02 at 12.06.50 PM.png (451×632 px, 65 KB)

Disable the "try syntax highlighting" popup for anonymous users

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove 'Try syntax highlighting' popup for all usersmediawiki/extensions/CodeMirrormaster+148 -418
Customize query in gerrit

Related Objects
Search...

Event Timeline

• TBolliger created this task.Apr 3 2018, 2:03 PM
• TBolliger updated the task description. (Show Details)
Niharika added a comment.Apr 3 2018, 8:14 PM

Yeah, I think disabling popup for anons altogether is the best idea.

Niharika moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Apr 3 2018, 8:14 PM
Niharika renamed this task from The tooltip for Syntax Highlighting should only appear once for logged-out (anonymous) users to Kill popups.Apr 3 2018, 10:55 PM
Niharika set the point value for this task to 2.
• TBolliger renamed this task from Kill popups to Disable the "try syntax highlighting" popup for anonymous users.Apr 5 2018, 12:47 PM
• TBolliger updated the task description. (Show Details)

Renaming this so we remember what in the heck this is about in the future. 😆

• TBolliger moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.Apr 11 2018, 10:39 PM
• TBolliger renamed this task from Disable the "try syntax highlighting" popup for anonymous users to Disable the "try syntax highlighting" popup for all users.Apr 11 2018, 11:54 PM
• TBolliger edited projects, added Community-Tech-Sprint; removed Community-Tech.
gh87 unsubscribed.Apr 12 2018, 1:19 AM
gerritbot subscribed.Apr 12 2018, 10:14 PM

Change 425917 had a related patch set uploaded (by MusikAnimal; owner: MusikAnimal):
[mediawiki/extensions/CodeMirror@master] Remove 'Try syntax highlighting' popup for all users

https://gerrit.wikimedia.org/r/425917

gerritbot added a project: Patch-For-Review.Apr 12 2018, 10:14 PM
• MusikAnimal claimed this task.Apr 12 2018, 10:14 PM
• MusikAnimal moved this task from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.
gerritbot added a comment.Apr 18 2018, 9:02 PM

Change 425917 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Remove 'Try syntax highlighting' popup for all users

https://gerrit.wikimedia.org/r/425917

Niharika closed this task as Resolved.Apr 18 2018, 9:53 PM
Niharika moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.
Liuxinyu970226 unsubscribed.Apr 20 2018, 1:07 PM
Liuxinyu970226 moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.May 5 2018, 12:25 AM
• TBolliger moved this task from Q1 2018-19 to Archive on the Community-Tech-Sprint board.May 9 2018, 11:21 PM
Niharika edited projects, added Community-Tech; removed Community-Tech-Sprint.Jun 26 2018, 11:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits