Page MenuHomePhabricator
Create Task
Maniphest T191310

Show changes in moved paragraphs for mobile
Closed, ResolvedPublic
Actions

Description

This is the umbrella ticket for the work around show changes in moved paragraphs - mobile edition.
Like the desktop version, this change also has to happen in the wikidiff2 library, but it does not touch the same code.

Expected steps:

  • prepare a third test wiki that shows the mobile diff view
  • draft patch
  • test that desktop diff really didn't change
  • test that this is really improving things
  • add a feature flag so that changes only go live once the frontend was updated as well
  • support visual improvements to empty lines via CSS class
  • deploy updated version of wikidiff2
  • enable feature flag to show moved paragraphs on mobile for all wikis

Details

SubjectRepoBranchLines +/-
show changes in moved lines, mobile/inline outputmediawiki/php/wikidiff2master+79 -23
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lea_WMDE triaged this task as Medium priority.Apr 3 2018, 3:24 PM
Lea_WMDE created this task.
Lea_WMDE closed subtask T191311: Set up test server for testing the mobile view of "show changes in moved paragraphs" as Resolved.Apr 19 2018, 3:35 PM
gerritbot subscribed.May 2 2018, 4:10 PM

Change 426025 had a related patch set uploaded (by Tobias Gritschacher; owner: Jkroll):
[mediawiki/php/wikidiff2@master] show changes in moved moved lines, mobile/inline output

https://gerrit.wikimedia.org/r/426025

gerritbot added a project: Patch-For-Review.May 2 2018, 4:10 PM
• jkroll closed subtask T191313: Create a first patch for "show changes in moved paragraphs for mobile" as Resolved.May 3 2018, 2:09 PM
• jkroll closed subtask T193640: Make sure that desktop version of the diffs did not change after the mobile version was introduced as Resolved.May 3 2018, 2:12 PM
Lea_WMDE reopened subtask T191313: Create a first patch for "show changes in moved paragraphs for mobile" as Open.May 3 2018, 3:46 PM
Lea_WMDE reopened subtask T193640: Make sure that desktop version of the diffs did not change after the mobile version was introduced as Open.May 3 2018, 3:48 PM
Lea_WMDE updated the task description. (Show Details)May 8 2018, 10:00 AM
Lea_WMDE updated the task description. (Show Details)May 8 2018, 1:41 PM
Lea_WMDE updated the task description. (Show Details)May 8 2018, 1:43 PM
Lea_WMDE edited parent tasks, added: T146781: Show changes in moved text chunks (C++); removed: T139603: Show text changes when moving text chunks (#2).May 9 2018, 1:59 PM
gerritbot added a comment.May 11 2018, 10:50 AM

Change 426025 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Jkroll):
[mediawiki/php/wikidiff2@master] show changes in moved lines, mobile/inline output

https://gerrit.wikimedia.org/r/426025

gerritbot added a comment.May 15 2018, 7:23 AM

Change 426025 merged by jenkins-bot:
[mediawiki/php/wikidiff2@master] show changes in moved lines, mobile/inline output

https://gerrit.wikimedia.org/r/426025

Lea_WMDE updated the task description. (Show Details)May 16 2018, 10:28 AM
Lea_WMDE closed subtask T191313: Create a first patch for "show changes in moved paragraphs for mobile" as Resolved.
Lea_WMDE closed subtask T193640: Make sure that desktop version of the diffs did not change after the mobile version was introduced as Resolved.
Lea_WMDE closed subtask T193638: Create minimal CSS to make mobile changes testable as Resolved.May 16 2018, 10:30 AM
Lea_WMDE merged a task: T180122: Show text changes in moved paragraphs on mobile.May 23 2018, 12:50 PM
Lea_WMDE added a subscriber: • Prtksxna.
Lea_WMDE closed subtask T194146: Make sure show changes in moved paragraphs for mobile really improves things as Resolved.May 23 2018, 1:42 PM
Jdlrobson closed subtask T195371: Create a test server for show changes in moved paragraphs on mobile as Resolved.Jun 15 2018, 7:56 PM
Jdlrobson added a subtask: T197491: Implement new design for moved paragraphs in diffs on mobile.
Lea_WMDE closed subtask T194271: Change config to disable new mobile behavior on all wikis except beta as Resolved.Jun 16 2018, 8:02 AM
Jdlrobson added a subtask: T197729: wikidiff2 creating ins and del elements with single empty character element.Jun 19 2018, 11:05 PM
gerritbot added a comment.Jun 19 2018, 11:09 PM

Change 441143 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Show moved diffs in mobile view when present

https://gerrit.wikimedia.org/r/441143

gerritbot added a comment.Jun 19 2018, 11:23 PM

Change 441144 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Smooth scrolling for jumping between moved paragraphs

https://gerrit.wikimedia.org/r/441144

• Vvjjkkii reopened subtask T195371: Create a test server for show changes in moved paragraphs on mobile as Open.Jul 1 2018, 1:08 AM
• Vvjjkkii reopened subtask T194271: Change config to disable new mobile behavior on all wikis except beta as Open.Jul 1 2018, 1:11 AM
• Vvjjkkii reopened subtask T194146: Make sure show changes in moved paragraphs for mobile really improves things as Open.
• Vvjjkkii reopened subtask T193640: Make sure that desktop version of the diffs did not change after the mobile version was introduced as Open.
• Vvjjkkii reopened subtask T193638: Create minimal CSS to make mobile changes testable as Open.
CommunityTechBot closed subtask T195371: Create a test server for show changes in moved paragraphs on mobile as Resolved.Jul 2 2018, 4:40 AM
CommunityTechBot closed subtask T194271: Change config to disable new mobile behavior on all wikis except beta as Resolved.Jul 2 2018, 6:02 AM
CommunityTechBot closed subtask T194146: Make sure show changes in moved paragraphs for mobile really improves things as Resolved.Jul 2 2018, 6:22 AM
CommunityTechBot closed subtask T193640: Make sure that desktop version of the diffs did not change after the mobile version was introduced as Resolved.Jul 2 2018, 2:11 PM
CommunityTechBot closed subtask T193638: Create minimal CSS to make mobile changes testable as Resolved.
ovasileva closed subtask T197491: Implement new design for moved paragraphs in diffs on mobile as Resolved.Jul 10 2018, 2:14 PM
WMDE-Fisch renamed this task from Show changes in moved paragraphs for mobile to Show changes in moved paragraphs for mobile.Jul 17 2018, 1:20 PM
WMDE-Fisch updated the task description. (Show Details)
Lea_WMDE closed subtask T197729: wikidiff2 creating ins and del elements with single empty character element as Resolved.Aug 3 2018, 6:47 AM
WMDE-Fisch added a subtask: T199800: Enabling moved paragraphs everywhere and for mobile diffs.Aug 20 2018, 12:31 PM
thiemowmde closed subtask T199800: Enabling moved paragraphs everywhere and for mobile diffs as Resolved.Aug 23 2018, 3:26 PM
WMDE-Fisch updated the task description. (Show Details)Aug 23 2018, 3:30 PM
WMDE-Fisch subscribed.

@Lea_WMDE I guess this can be closed now \o/

Lea_WMDE closed this task as Resolved.Aug 23 2018, 3:32 PM
Lea_WMDE claimed this task.
Aklapper added a project: MediaWiki-Page-history.Sep 20 2019, 7:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL