Maniphest T191349

No error messages for unsuccessful publishing with invalid target title
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Apr 3 2018, 9:10 PM

Description

In CX2, attempting to publish an article with invalid characters in the title (Help:Page_name#Restrictions) will not result in any error messages:

CX1 will helpfully inform users about errors during publishing:

- "An error occurred while publishing the translation. Please try to publish the page again. Error: The requested page title contains invalid characters:..."
"An error occurred while publishing the translation. Please try to publish the page again. Error: error"

The page will be stuck in "Publishing..." state. The Console displays the following error:

[CX] Invalid target title
mw.cx.TranslationController.onTargetTitleChange	
oo.EventEmitter.emit
ve.init.mw.CXTarget.onTargetTitleChange
oo.EventEmitter.emit	
oo.EventEmitter.emit	
OO.ui.InputWidget.setValue	
(anonymous)	
setTimeout (async)		
OO.ui.InputWidget.onEdit	
dispatch	
elemData.handle

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Show invalid title error	mediawiki/extensions/ContentTranslation	master	+39 -20

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Pginer-WMF	T188732 CX2: Publishing support
Open	None	T189488 CX2: Show translation issues
Resolved	• Petar.petkovic	T190804 CX2: Error for invalid characters in the title
Resolved	• Petar.petkovic	T191349 No error messages for unsuccessful publishing with invalid target title

Event Timeline

Etonkovidova created this task.Apr 3 2018, 9:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 3 2018, 9:10 PM

Etonkovidova mentioned this in T189291: CX2: Communicate publishing is in progress.Apr 3 2018, 9:14 PM

Etonkovidova added a parent task: T189488: CX2: Show translation issues.Apr 6 2018, 12:32 AM

Etonkovidova added a parent task: T190804: CX2: Error for invalid characters in the title.Apr 6 2018, 12:37 AM

Change 425727 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Show invalid title error

https://gerrit.wikimedia.org/r/425727

gerritbot added a project: Patch-For-Review.Apr 12 2018, 12:04 AM

Pginer-WMF triaged this task as Medium priority.Apr 12 2018, 10:38 AM

Pginer-WMF moved this task from Needs Triage to CX2 on the ContentTranslation board.

Pginer-WMF added a project: Language-2018-Apr-June.

• Petar.petkovic renamed this task from [cx2-testing] No error messages for unsuccessful publishing to No error messages for unsuccessful publishing with invalid target title.Apr 12 2018, 11:10 AM

• Petar.petkovic claimed this task.

• Petar.petkovic updated the task description. (Show Details)

• Petar.petkovic moved this task from Backlog to In Review on the Language-2018-Apr-June board.

This patch is restoring what we have in CX1. When user tries to publish with invalid target title, publishing fails and error message is shown. After T190804, publishing the page with invalid character in the title will be impossible.

• Petar.petkovic mentioned this in T162768: CX2: Basic translation publishing and error handling.Apr 12 2018, 11:48 AM

Change 425727 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Show invalid title error

https://gerrit.wikimedia.org/r/425727

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)).Apr 23 2018, 3:00 PM

• Petar.petkovic moved this task from In Review to QA on the Language-2018-Apr-June board.Apr 23 2018, 3:11 PM

• Petar.petkovic removed a project: Patch-For-Review.

Checked in cx2 - the error message is as in cx1:

Screen Shot 2018-04-27 at 12.33.00 PM.png (414×983 px, 55 KB)

The Console displays the error, but it may be addressed in https://phabricator.wikimedia.org/T190804:
[CX] Publishing failed {"code":"invalidtitle","info":"Bad title \"\".","*":"See http://cx2-testing.wmflabs.org/api.php for API usage.

• Petar.petkovic moved this task from QA to Done on the Language-2018-Apr-June board.Apr 27 2018, 9:38 PM

	F17345710: Screen Shot 2018-04-27 at 12.33.00 PM.png
	Apr 27 2018, 7:47 PM

No error messages for unsuccessful publishing with invalid target titleClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

No error messages for unsuccessful publishing with invalid target title
Closed, ResolvedPublic
Actions

Related Objects
Search...